Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760977AbYGaDUd (ORCPT ); Wed, 30 Jul 2008 23:20:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757079AbYGaDUZ (ORCPT ); Wed, 30 Jul 2008 23:20:25 -0400 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:38952 "EHLO cdptpa-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756023AbYGaDUY (ORCPT ); Wed, 30 Jul 2008 23:20:24 -0400 Date: Wed, 30 Jul 2008 23:20:27 -0400 Message-ID: <87sktqyc1w.wl%ysato@users.sourceforge.jp> From: Yoshinori Sato To: Andrew Morton Cc: vapier.adi@gmail.com, linux-kernel@vger.kernel.org, Jeremy Fitzhardinge Subject: Re: [PATCH] Missing symbol prefix on vmlinux.lds.h In-Reply-To: <20080730190659.fcf01dff.akpm@linux-foundation.org> References: <87provuzwk.wl%ysato@users.sourceforge.jp> <8bd0f97a0807300911n4ae81b70v97276abf612f6b3e@mail.gmail.com> <87hca7npmp.wl%ysato@users.sourceforge.jp> <20080730130117.3495cba9.akpm@linux-foundation.org> <87tze6yk3z.wl%ysato@users.sourceforge.jp> <20080730190659.fcf01dff.akpm@linux-foundation.org> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.2 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2060 Lines: 69 At Wed, 30 Jul 2008 19:06:59 -0700, Andrew Morton wrote: > > On Wed, 30 Jul 2008 20:26:24 -0400 Yoshinori Sato wrote: > > > Sorry. > > > > I got error ARCH=h8300. > > init/main.c:781: undefined reference to `___early_initcall_end' > > > > Same problem have > > __start___bug_table > > __stop___bug_table > > __tracedata_start > > __tracedata_end > > __per_cpu_start > > __per_cpu_end > > > > If define symbol in vmlinux.lds, Use VMLINUX_SYMBOL macro. > > VMLINUX_SYMBOL is add prefix charactor. > > > > Signed-off-by: Yoshinori Sato > > > > --- > > include/asm-generic/vmlinux.lds.h | 14 +++++++------- > > 1 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > > index 6d88a92..04cae96 100644 > > --- a/include/asm-generic/vmlinux.lds.h > > +++ b/include/asm-generic/vmlinux.lds.h > > @@ -333,9 +333,9 @@ > > #define BUG_TABLE \ > > . = ALIGN(8); \ > > __bug_table : AT(ADDR(__bug_table) - LOAD_OFFSET) { \ > > - __start___bug_table = .; \ > > + VMLINUX_SYMBOL(__start___bug_table) = .; \ > > *(__bug_table) \ > > - __stop___bug_table = .; \ > > + VMLINUX_SYMBOL(__stop___bug_table) = .; \ > > } > > #else > > #define BUG_TABLE > > Strange. The code you're fixing there was added by > > commit 7664c5a1da4711bb6383117f51b94c8dc8f3f1cd > Author: Jeremy Fitzhardinge > Date: Fri Dec 8 02:36:19 2006 -0800 > > [PATCH] Generic BUG implementation > > > over a year ago. I doubt if h8300 has been broken for that long, so > something else must have triggered this failure. > > Do you know what it was? I don't know. Check it. -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/