Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754347AbYGaHA0 (ORCPT ); Thu, 31 Jul 2008 03:00:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752958AbYGaHAK (ORCPT ); Thu, 31 Jul 2008 03:00:10 -0400 Received: from nf-out-0910.google.com ([64.233.182.191]:34666 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752936AbYGaHAI (ORCPT ); Thu, 31 Jul 2008 03:00:08 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=to:subject:date:user-agent:cc:references:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :message-id:from; b=K+TGWEnkl5t0axdK4fKqCavF6Sg6NHpPWuEG9mqj4Mnw1EQYGeUVni7D6t/AcfeWYf 2ueQR+OA0nKC+twUZzG/WP6vlxd8k4GRERynJk8FkSqu00O0uo82sdujzIQx/iLvQeja itArWwFyh0yS/nHpRQO5yuOniEA6NTJWGK+Cc= To: Peter Chubb , John Linville Subject: Re: Fixing rt2500pci [PATCH] Date: Thu, 31 Jul 2008 09:21:41 +0200 User-Agent: KMail/1.9.9 Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org References: <87tze8vu18.wl%peterc@chubb.wattle.id.au> <200807302115.03865.IvDoorn@gmail.com> <87vdym6fct.wl%peterc@chubb.wattle.id.au> In-Reply-To: <87vdym6fct.wl%peterc@chubb.wattle.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807310921.42176.IvDoorn@gmail.com> From: Ivo van Doorn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1983 Lines: 50 On Thursday 31 July 2008, Peter Chubb wrote: > > In kernel version 2.6.26-rc9 my wireless LAN card worked; but in the > released 2.6.26, my RaLink rt2500 card wouldn't associate. > > Git-bisect led me to this patch: > > 61486e0f68d1f8966c09b734566a187d42d65c54 > rt2x00: Remove ieee80211_tx_control argument from write_tx_desc() > > I believe that there is a problem with that patch --- it > (inadvertantly) removes an extra line of code, that used to set the > DATABYTE_COUNT field. > > This patch reinstates that line, and with it my card works again. > > Signed-off-by: Peter Chubb > Acked-by: Ivo van Doorn Thanks, John, please push this patch upstream. This one is really important. :) > diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c > index 1724ce9..4ba2165 100644 > --- a/drivers/net/wireless/rt2x00/rt2500pci.c > +++ b/drivers/net/wireless/rt2x00/rt2500pci.c > @@ -1198,6 +1198,7 @@ static void rt2500pci_write_tx_desc(struct rt2x00_dev *rt2x00dev, > rt2x00_set_field32(&word, TXD_W0_IFS, txdesc->ifs); > rt2x00_set_field32(&word, TXD_W0_RETRY_MODE, > test_bit(ENTRY_TXD_RETRY_MODE, &txdesc->flags)); > + rt2x00_set_field32(&word, TXD_W0_DATABYTE_COUNT, skbdesc->data_len); > rt2x00_set_field32(&word, TXD_W0_CIPHER_ALG, CIPHER_NONE); > rt2x00_desc_write(txd, 0, word); > } > > -- > Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au > http://www.ertos.nicta.com.au ERTOS within National ICT Australia > -- > Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au > http://www.ertos.nicta.com.au ERTOS within National ICT Australia > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/