Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800AbYGaIAI (ORCPT ); Thu, 31 Jul 2008 04:00:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750812AbYGaH7z (ORCPT ); Thu, 31 Jul 2008 03:59:55 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:46339 "EHLO ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbYGaH7y convert rfc822-to-8bit (ORCPT ); Thu, 31 Jul 2008 03:59:54 -0400 Date: Thu, 31 Jul 2008 10:00:23 +0200 From: Sebastien Dugue To: Chirag Jog Cc: J?rgen Mell , Thomas Gleixner , LKML , rt-users , Steven Rostedt , Clark Williams , Peter Zijlstra , Josh Triplett , "Timothy R. Chavez" Subject: Re: [PATCH] Fix Bug messages Message-ID: <20080731100023.0221ec2b@bull.net> In-Reply-To: <20080730171842.GB3420@linux.vnet.ibm.com> References: <200807301101.32417.j.mell@t-online.de> <20080730171842.GB3420@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.2.0 (GTK+ 2.12.2; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3096 Lines: 76 On Wed, 30 Jul 2008 22:48:42 +0530 Chirag Jog wrote: > * J?rgen Mell [2008-07-30 11:01:32]: > > > Hello Thomas, > > > > On Wednesday, 30. July 2008, Thomas Gleixner wrote: > > > We are pleased to announce the 2.6.26-rt1 tree, which can be > > > downloaded from the location: > > > > I have tried the new kernel and have some good news and some bad news: > > > > The good news: The machine boots and seems to run without major problems. > > > > The bad news: It produces continuously lots of bug messages in the error > > logs (cf. attached dmesg.tgz). The error at rtmutex.c:743 was already > > present in 2.6.25-rt* when ACPI was enabled. The 'using smp_processor_id > > () in preemptible code' is new here with 2.6.26. > > > > Machine is an old Athlon XP (single core) on an EPOX mainboard with VIA > > chipset. > > > > If I can help with testing, please let me know. > > > > Bye, > > Jürgen > > > > > This patch should solve some of the bug messages. > It does two things: > 1. Change rt_runtime_lock to be a raw spinlock as the comment above it > says: it is nested inside the rq lock. > > 2. Change mnt_writers to be a per_cpu locked variable. > This eliminates the need for the codepath to disable preemption and > then potentially sleep, leading to the BUG messages > > Signed-Off-By: Chirag Neat, the only remaining BUGs I see are from sock_prot_inuse_add() BUG: using smp_processor_id() in preemptible [00000000] code: arping/1916 caller is .sock_prot_inuse_add+0x30/0x80 Call Trace: [c0000000eed2f910] [c000000000010304] .show_stack+0x70/0x1bc (unreliable) [c0000000eed2f9c0] [c0000000001a2340] .debug_smp_processor_id+0x138/0x168 [c0000000eed2fa70] [c0000000002181f4] .sock_prot_inuse_add+0x30/0x80 [c0000000eed2fb10] [c00000000026d96c] .udp_lib_get_port+0x2a8/0x320 [c0000000eed2fbc0] [c000000000275b30] .inet_bind+0x168/0x248 [c0000000eed2fc60] [c000000000215024] .sys_bind+0x98/0xdc [c0000000eed2fd90] [c0000000002370bc] .compat_sys_socketcall+0xcc/0x214 [c0000000eed2fe30] [c0000000000086ac] syscall_exit+0x0/0x40 BUG: arping:1916 task might have lost a preemption check! Call Trace: [c0000000eed2f890] [c000000000010304] .show_stack+0x70/0x1bc (unreliable) [c0000000eed2f940] [c00000000004e298] .preempt_enable_no_resched+0x60/0x78 [c0000000eed2f9c0] [c0000000001a2348] .debug_smp_processor_id+0x140/0x168 [c0000000eed2fa70] [c0000000002181f4] .sock_prot_inuse_add+0x30/0x80 [c0000000eed2fb10] [c00000000026d96c] .udp_lib_get_port+0x2a8/0x320 [c0000000eed2fbc0] [c000000000275b30] .inet_bind+0x168/0x248 [c0000000eed2fc60] [c000000000215024] .sys_bind+0x98/0xdc [c0000000eed2fd90] [c0000000002370bc] .compat_sys_socketcall+0xcc/0x214 [c0000000eed2fe30] [c0000000000086ac] syscall_exit+0x0/0x40 ... Thanks, Sebastien. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/