Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753689AbYGaIaL (ORCPT ); Thu, 31 Jul 2008 04:30:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751298AbYGaI3w (ORCPT ); Thu, 31 Jul 2008 04:29:52 -0400 Received: from smtp239.poczta.interia.pl ([217.74.64.239]:46496 "EHLO smtp239.poczta.interia.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbYGaI3u convert rfc822-to-8bit (ORCPT ); Thu, 31 Jul 2008 04:29:50 -0400 Date: 31 Jul 2008 10:29:45 +0200 From: krzysztof.h1@poczta.fm Subject: Re: [Linux-fbdev-devel] [PATCH] atyfb_base.c: fix warning To: "M. Asselstine" , Alexander Beregalov Cc: "kernel-janitors@vger.kernel.org" , "syrjala@sci.fi" , "linux-fbdev-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "adaplas@gmail.com" MIME-Version: 1.0 Content-Type: TEXT/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-ORIGINATE-IP: 83.17.101.58 X-Mailer: PSE Message-Id: <20080731082945.6AEA31E3074@f03.poczta.interia.pl> X-EMID: 7a840acc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 33 > On Wed, Jul 30, 2008 at 5:03 PM, Alexander Beregalov > wrote: > > From: Alexander Beregalov > > > > atyfb_base.c: fix warning > > > > drivers/video/aty/atyfb_base.c:2663: warning: 'aty_resume_chip' defined > > but not used > > > > Signed-off-by: Alexander Beregalov > > Cc: Ville Syrjala > > Cc: Antonino A. Daplas > > Looks good, should you maybe move the aty_resume_chip() up into the > existing #if defined(CONFIG_PM) &&... that atyfb_pci_resume() is in? > Not sure, just a thought. > The same thought has crossed my mind. Kill the forward declaration and move this short function before atyfb_pci_resume(). Regards, Krzysztof ---------------------------------------------------------------------- W kosciele tez zdarzaja sie wpadki! Smieszny filmik >>> http://link.interia.pl/f1e61 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/