Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754961AbYGaJwP (ORCPT ); Thu, 31 Jul 2008 05:52:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751852AbYGaJv6 (ORCPT ); Thu, 31 Jul 2008 05:51:58 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:38706 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbYGaJv6 (ORCPT ); Thu, 31 Jul 2008 05:51:58 -0400 Subject: Re: [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices From: David Woodhouse To: David Miller , torvalds@linux-foundation.org Cc: thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org, michael@free-electrons.com In-Reply-To: <20080731.024027.162488608.davem@davemloft.net> References: <20080731092703.661994657@free-electrons.com> <20080731.024027.162488608.davem@davemloft.net> Content-Type: text/plain Date: Thu, 31 Jul 2008 10:51:52 +0100 Message-Id: <1217497912.3454.95.camel@pmac.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 41 On Thu, 2008-07-31 at 02:40 -0700, David Miller wrote: > From: Thomas Petazzoni > Date: Thu, 31 Jul 2008 11:27:03 +0200 > > > Changes since previous post: > > > > * Add Matt Mackall's Signed-off-by on all patches > > * Make bonding and bridging select ethtool in the ethtool-related > > patch. > > The ethtool config option needs to be selected by CONFIG_INET as well, > as per the things I described today. Which erodes it's usefulness > tremendously. > > I also am keeping my stance that I have no current intention of > applying these patches. I would very much like you to reconsider, Dave. We can make them default to 'y' and hide them behind CONFIG_EMBEDDED, and put in a scary help text that tells people _never_ to turn it off -- and hell, you can even make a taint flag for it if you like. But there are a lot of people who really don't need these features and really want the option of leaving them out. Perhaps we should add a warning printk when one of these features is 'required' but absent. That would help to make it clear when someone has disabled a feature which they shouldn't have disabled. Refusing to apply the patches just means that either those people will get them from elsewhere, or that their kernel will be more bloated than it needs to be. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/