Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746AbYGaKyy (ORCPT ); Thu, 31 Jul 2008 06:54:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752689AbYGaKya (ORCPT ); Thu, 31 Jul 2008 06:54:30 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:38813 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbYGaKy3 (ORCPT ); Thu, 31 Jul 2008 06:54:29 -0400 Subject: Re: [patch 3/4] Configure out ethtool support From: David Woodhouse To: David Miller Cc: bhutchings@solarflare.com, thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org, michael@free-electrons.com, mpm@selenic.com, jgarzik@pobox.com, netdev@vger.kernel.org, akpm@linux-foundation.org In-Reply-To: <20080731.034904.190066778.davem@davemloft.net> References: <20080731092703.661994657@free-electrons.com> <20080731093221.236840420@free-electrons.com> <20080731104004.GN10471@solarflare.com> <20080731.034904.190066778.davem@davemloft.net> Content-Type: text/plain Date: Thu, 31 Jul 2008 11:54:24 +0100 Message-Id: <1217501664.3454.151.camel@pmac.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 23 On Thu, 2008-07-31 at 03:49 -0700, David Miller wrote: > From: Ben Hutchings > Date: Thu, 31 Jul 2008 11:40:05 +0100 > > > You also need to conditionalise dev_disable_lro(). > > That can only be done once the CONFIG_ETHTOOL select statement > is added for CONFIG_INET. > > Which basically makes this CONFIG_ETHTOOL thing completely pointless. Other potential approaches include not enabling LRO by default if !CONFIG_ETHTOOL. Or having the driver(s) which _do_ enable LRO by default 'select ETHTOOL'. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/