Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756787AbYGaPbV (ORCPT ); Thu, 31 Jul 2008 11:31:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752866AbYGaPbI (ORCPT ); Thu, 31 Jul 2008 11:31:08 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:41101 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752449AbYGaPbG (ORCPT ); Thu, 31 Jul 2008 11:31:06 -0400 Date: Thu, 31 Jul 2008 17:29:26 +0200 From: Ingo Molnar To: Vivek Goyal Cc: Simon Horman , Andrew Morton , Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Terry Loftin , "Eric W. Biederman" , Linus Torvalds , Paul Mundt , Paul Mackerras , linuxppc-dev@ozlabs.org Subject: Re: [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent section Message-ID: <20080731152926.GA20909@elte.hu> References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080728211156.GB9985@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080728211156.GB9985@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 935 Lines: 27 * Vivek Goyal wrote: > o Move elfcorehdr_addr definition in arch dependent crash dump file. This is > equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of > CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be > used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or > not. > > Signed-off-by: Vivek Goyal > --- > > arch/x86/kernel/crash_dump_32.c | 3 +++ > arch/x86/kernel/crash_dump_64.c | 3 +++ > arch/x86/kernel/setup.c | 8 +++++++- > 3 files changed, 13 insertions(+), 1 deletion(-) the x86 bits look fine to me. Acked-by: Ingo Molnar Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/