Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753754AbYGaQKh (ORCPT ); Thu, 31 Jul 2008 12:10:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751223AbYGaQK1 (ORCPT ); Thu, 31 Jul 2008 12:10:27 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:38166 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbYGaQK1 (ORCPT ); Thu, 31 Jul 2008 12:10:27 -0400 Date: Thu, 31 Jul 2008 17:10:24 +0100 From: Al Viro To: Miklos Szeredi Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch resend] vfs: move executable checking into ->permission() Message-ID: <20080731161024.GL28946@ZenIV.linux.org.uk> References: <20080731003332.GJ28946@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 25 On Thu, Jul 31, 2008 at 01:41:58PM +0200, Miklos Szeredi wrote: > On Thu, 31 Jul 2008, Al Viro wrote: > > On Wed, Jul 30, 2008 at 03:02:03PM +0200, Miklos Szeredi wrote: > > > static int coda_ioctl_permission(struct inode *inode, int mask) > > > { > > > - return 0; > > > + return check_execute(dentry->d_inode, mask); > > > } > > > > Er? > > a) mismerge from dentry-based variant > > Yeah, crappy patch. Agree on all other comments as well, thanks for > the review. Hrm... OK, behaviour change for permission() on bdev/cdev/pipe is not a problems... I'll apply it, but if anybody has better suggestions for helper name, please yell. "execute_ok()" sounds very odd... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/