Message-ID: <48920174.8000001@beta.intcomgrp.com>
Date: Thu, 31 Jul 2008 14:16:20 -0400
From: James Kosin <jkosin@beta.intcomgrp.com>
Organization: International Communications Group, Inc.
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Removes extra checking in kernel/cpuset.c
References: <aVIzQ-Oh-23@gated-at.bofh.it>
In-Reply-To: <aVIzQ-Oh-23@gated-at.bofh.it>
OpenPGP: id=7BB59129
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigEF22272A1DC3068949A2801B"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1874
Lines: 50

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigEF22272A1DC3068949A2801B
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable

Rakib Mullick wrote:
> Hello guys, this patch removes an extra checking over 'cs' in
> functions 'guarantee_online_cpus' and 'guarantee_online_mems'.
>=20
> Thanks.
>=20
> Signed-off-by: Md.Rakib H. Mullick (rakib.mullick@gmail.com)
>=20

I'd have to NAK this one as well.  2-reasons:
1)  Your patch is guaranteed to generate a NULL pointer dereference at=20
some point.  You keep using cs; and assigning cs =3D cs->parent in the=20
loop, at some point you may end up at the TOP of the tree where=20
cs->parent =3D=3D NULL.
2)  The change breaks the actual meaning of the code.  Which is=20
suggesting my the short snippet, find an entry (while loop)... if the=20
entry is found (if cs test), do this otherwise BUG out.  Your code is=20
saying, if cs is not NULL initially... find someplace then do something. =

  The function never BUGS out unless someone calls with cs NULL initially=
=2E

James Kosin


--------------enigEF22272A1DC3068949A2801B
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkiSAXQACgkQkNLDmnu1kSnfcgCfV7O5ouzQLIq1Y8i9g+tu2H/o
SDEAn2JBl8g/DZmVggFtgFaLk4rTbmFL
=QgjK
-----END PGP SIGNATURE-----

--------------enigEF22272A1DC3068949A2801B--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/