Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759456AbYGaWBI (ORCPT ); Thu, 31 Jul 2008 18:01:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755993AbYGaWAv (ORCPT ); Thu, 31 Jul 2008 18:00:51 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:36346 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755476AbYGaWAu (ORCPT ); Thu, 31 Jul 2008 18:00:50 -0400 Date: Thu, 31 Jul 2008 14:59:34 -0700 From: Andrew Morton To: Al Viro Cc: eparis@redhat.com, zhangxiliang@cn.fujitsu.com, sgrubb@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix the bug of using AUDIT_STATUS_RATE_LIMIT when set fail, no error output. Message-Id: <20080731145934.cc3893de.akpm@linux-foundation.org> In-Reply-To: <20080731160438.GK28946@ZenIV.linux.org.uk> References: <48911F47.50606@cn.fujitsu.com> <1217474150.2902.76.camel@localhost.localdomain> <20080731160438.GK28946@ZenIV.linux.org.uk> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 21 On Thu, 31 Jul 2008 17:04:38 +0100 Al Viro wrote: > On Wed, Jul 30, 2008 at 11:15:50PM -0400, Eric Paris wrote: > > On Thu, 2008-07-31 at 10:11 +0800, zhangxiliang wrote: > > > When the "status_get->mask" is "AUDIT_STATUS_RATE_LIMIT || AUDIT_STATUS_BACKLOG_LIMIT". > > > If "audit_set_rate_limit" fails and "audit_set_backlog_limit" succeeds, the "err" value will be greater than or equal to 0. It will miss the failure of rate set. > > > > > > Signed-off-by: Zhang Xiliang > > > > man, it gives me the heebee jeebies with the coding style but it follows > > everything else > > Sanitized, applied, pushed to audit-current (audit.b53) That tree doesn't appear to be in the linux-next lineup. Fixable, please? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/