Return-Path: <linux-kernel-owner+w=401wt.eu-S1756552AbYHAIBZ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756552AbYHAIBZ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Aug 2008 04:01:25 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752652AbYHAIBP
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 1 Aug 2008 04:01:15 -0400
Received: from fg-out-1718.google.com ([72.14.220.159]:26845 "EHLO
	fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752556AbYHAIBO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Aug 2008 04:01:14 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=TCNUm+NNU+DxpHOis+NnWLG8o5txuxb9dYjD2CZ0ZvVM0Vqvu5poCaoq3Xo0QZThRk
         2MIS+8/WYI5YrbWCBXFtkwfaxllr5D7XAU1oq3gJJl2agfMRHJ2a+FQ31WfW+oHNuVIR
         Z5ATgnDHuqIwOPtdlh1UTE+0eBeS5rj07H2h0=
Message-ID: <4892C2CA.7010003@gmail.com>
Date: Fri, 01 Aug 2008 10:01:14 +0200
From: Jiri Slaby <jirislaby@gmail.com>
User-Agent: Thunderbird 2.0.0.16 (X11/20080720)
MIME-Version: 1.0
To: Dave Young <hidave.darkstar@gmail.com>
CC: johannes@sipsolutions.net, akpm@linux-foundation.org,
       penberg@cs.helsinki.fi, tomasw@gmail.com, linux-kernel@vger.kernel.org,
       linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath5k : ath5k_config_interface deadlock fix
References: <20080801074014.GA3341@darkstar>
In-Reply-To: <20080801074014.GA3341@darkstar>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1683
Lines: 33

Dave Young napsal(a):
> In the drivers/net/wireless/ath5k/base.c, there's recursive locking of sc->lock
> This casue the kernel stuck
> 
> Bug report please see:
> http://lkml.org/lkml/2008/7/29/32
> 
> Fixed it by remove the lock in sub routine "ath5k_beacon_update",
> The ath5k_config_interface is the only caller to it.
> 
> [  171.430207] =============================================
> [  171.432140] [ INFO: possible recursive locking detected ]
> [  171.433113] 2.6.27-rc1-smp #4
> [  171.434079] ---------------------------------------------
> [  171.435039] ath5k_pci/2447 is trying to acquire lock:
> [  171.435990]  (&sc->lock){--..}, at: [<f89ee9b5>] ath5k_config_interface+0xd5/0x340 [ath5k]
> [  171.437046] 
> [  171.437048] but task is already holding lock:
> [  171.438903]  (&sc->lock){--..}, at: [<f89ee91d>] ath5k_config_interface+0x3d/0x340 [ath5k]
> [  171.439953] 
> [  171.439954] other info that might help us debug this:
> [  171.441795] 3 locks held by ath5k_pci/2447:
> [  171.442729]  #0:  ((name)){--..}, at: [<c013a122>] run_workqueue+0x102/0x1d0
> [  171.443800]  #1:  (&(&local->scan_work)->work){--..}, at: [<c013a122>] run_workqueue+0x102/0x1d0
> [  171.444859]  #2:  (&sc->lock){--..}, at: [<f89ee91d>] ath5k_config_interface+0x3d/0x340 [ath5k]

Should be fixed already:
http://git.kernel.org/?p=linux/kernel/git/linville/wireless-2.6.git;a=commitdiff_plain;h=bc05116ab33d30342e2b4b1bcc6d6e1184e9df97
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/