Date: Fri, 1 Aug 2008 11:26:43 +0200
From: Rodolfo Giometti <giometti@enneenne.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: linux-kernel@vger.kernel.org, Anton Vorontsov <cbou@mail.ru>,
       David Woodhouse <dwmw2@infradead.org>
Message-ID: <20080801092643.GX8465@enneenne.com>
References: <1213794512-8245-1-git-send-email-giometti@linux.it> <20080619233411.GA27198@zarina> <20080620061345.GA9339@gundam.enneenne.com> <20080623063817.GA24051@zarina> <20080731210354.GW8465@enneenne.com> <20080801082853.GA19224@zarina>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080801082853.GA19224@zarina>
Organization: GNU/Linux Device Drivers, Embedded Systems and Courses
User-Agent: Mutt/1.5.16 (2007-06-11)
Subject: Re: [PATCH] power: support for Texas Instruments BQ27x00 battery
	managers.
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2107
Lines: 56

On Fri, Aug 01, 2008 at 12:28:53PM +0400, Anton Vorontsov wrote:
> > On Mon, Jun 23, 2008 at 10:38:17AM +0400, Anton Vorontsov wrote:
> > 
> > > Here is the patch to show the idea. I only tested it to build, so no
> > > guaranties that it will work on the actual hardware. :-)
> > > 
> > > This patch should be separated: one patch is for I2C subsystem
> > > maintainer (drivers/i2c/* changes) and another (drivers/power/* +
> > > include/linux/bq27x00.h) is for me.
> > 
> > On my system I need to specify 2 battery chips into the platform
> > specific file as follow (file is arch/arm/mach-pxa/wr1100.c):
> > 
> > 	static struct i2c_board_info __initdata wr1100_i2c_mux_devices[] = {
> > 	        {
> > 	                I2C_BOARD_INFO("bq27200", 0x55),
> > 	        },
> > 	};
> > 		
> >         i2c_register_board_info(2, wr1100_i2c_mux_devices,
> >                                         ARRAY_SIZE(wr1100_i2c_mux_devices));
> >         i2c_register_board_info(3, wr1100_i2c_mux_devices,
> >                                         ARRAY_SIZE(wr1100_i2c_mux_devices));
> > 
> > By using your solution I cannot use this code, is that right?
> 
> Why not? I think there should be no problem.

The platform_driver_register() conflicts with i2c_add_driver(),
doesn't it? O_o

> [...]
> > if you agree, I prefere resend my
> > patch without the #ifdef and the w1 support (since I cannot test it at
> > all) but living the possibility to add that support later.
> 
> Yes, that would be also fine.

Ok, since I cannot test the w1 subsystem at all, is better I provide
only tested code. :)

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/