Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750972AbYHAWvH (ORCPT ); Fri, 1 Aug 2008 18:51:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751320AbYHAWuw (ORCPT ); Fri, 1 Aug 2008 18:50:52 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:35164 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246AbYHAWuu (ORCPT ); Fri, 1 Aug 2008 18:50:50 -0400 From: "Rafael J. Wysocki" To: Matt Helsley , Andrew Morton Subject: Re: [PATCH 2/6] Container Freezer: Make refrigerator always available Date: Sat, 2 Aug 2008 00:53:17 +0200 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: Thomas Petazzoni , Paul Menage , Li Zefan , Linux-Kernel , Linux Containers , linux-pm@lists.linux-foundation.org, Cedric Le Goater , "Serge E. Hallyn" , Michael Opdenacker , linux-embedded@vger.kernel.org References: <20080801050659.924495279@us.ibm.com> <20080801162712.63721e8c@surf> <1217617689.25300.213.camel@localhost.localdomain> In-Reply-To: <1217617689.25300.213.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-7" Content-Disposition: inline Message-Id: <200808020053.18638.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha.home.local id m71MpHIG002836 Content-Length: 9506 Lines: 9 On Friday, 1 of August 2008, Matt Helsley wrote:> > On Fri, 2008-08-01 at 16:27 +-0200, Thomas Petazzoni wrote:> > Hi,> > > > Le Thu, 31 Jul 2008 22:07:01 -0700,> > Matt Helsley a +AOk-crit :> > > > > --- a/kernel/Makefile> > > +-+-+- b/kernel/Makefile> > > @@ -5,7 +-5,7 @@> > > obj-y = sched.o fork.o exec_domain.o panic.o printk.o +AFw> > > cpu.o exit.o itimer.o time.o softirq.o resource.o +AFw> > > sysctl.o capability.o ptrace.o timer.o user.o +AFw> > > - signal.o sys.o kmod.o workqueue.o pid.o +AFw> > > +- signal.o sys.o kmod.o workqueue.o pid.o freezer.o +AFw> > > > I have the impression that the code in kernel/power/process.c was> > compiled only if CONFIG_PM_SLEEP was set. Now that the code has been> > moved to kernel/freezer.c, it is unconditionnaly compiled in every> > kernel. Is that correct ?> >> > If so, is it possible to put this new feature under some> > CONFIG_SOMETHING option, for people who care about the kernel size ?> > How about making it depend on a combination of CONFIG variables?> Here's an RFC PATCH. Completely untested.> > Signed-off-by: Matt Helsley Can you please also make the contents of include/linux/freezer.h depend onCONFIG_FREEZER instead of CONFIG_PM_SLEEP? Also, I'm not really sure if kernel/power/Kconfig is the right place to defineCONFIG_FREEZER. Perhaps we should even move freezer.c from kernel/power to kerneland define CONFIG_FREEZER in Kconfig in there. Andrew, what do you think? > ---> kernel/Makefile | 3 +-+--> kernel/power/Kconfig | 3 +-+-+-> 2 files changed, 5 insertions(+-), 1 deletion(-)> > Index: linux-2.6.27-rc1-mm1/kernel/Makefile> ===================================================================> --- linux-2.6.27-rc1-mm1.orig/kernel/Makefile> +-+-+- linux-2.6.27-rc1-mm1/kernel/Makefile> @@ -5,7 +-5,7 @@> obj-y = sched.o fork.o exec_domain.o panic.o printk.o +AFw> cpu.o exit.o itimer.o time.o softirq.o resource.o +AFw> sysctl.o capability.o ptrace.o timer.o user.o +AFw> - signal.o sys.o kmod.o workqueue.o pid.o freezer.o +AFw> +- signal.o sys.o kmod.o workqueue.o pid.o +AFw> rcupdate.o extable.o params.o posix-timers.o +AFw> kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o mutex.o +AFw> hrtimer.o rwsem.o nsproxy.o srcu.o semaphore.o +AFw> @@ -24,6 +-24,7 @@ CFLAGS_REMOVE_sched_clock.o = -pg> CFLAGS_REMOVE_sched.o = -mno-spe -pg> endif> > +-obj-$(CONFIG_FREEZER) +-= freezer.o> obj-$(CONFIG_PROFILING) +-= profile.o> obj-$(CONFIG_SYSCTL_SYSCALL_CHECK) +-= sysctl_check.o> obj-$(CONFIG_STACKTRACE) +-= stacktrace.o> Index: linux-2.6.27-rc1-mm1/kernel/power/Kconfig> ===================================================================> --- linux-2.6.27-rc1-mm1.orig/kernel/power/Kconfig> +-+-+- linux-2.6.27-rc1-mm1/kernel/power/Kconfig> @@ -85,6 +-85,9 @@ config PM_SLEEP> depends on SUSPEND || HIBERNATION || XEN_SAVE_RESTORE> default y> > +-config FREEZER> +- def_bool PM_SLEEP || CGROUP_FREEZER> +-> config SUSPEND> bool "Suspend to RAM and standby"> depends on PM && ARCH_SUSPEND_POSSIBLE> > > > > ??????????????????`?? #: #' # #?????????????????????X????????????????????????????????????????????????????????????????????????????ͼ??n}??F??0???8???@???E???????@???1????????????????????????Z?? #A #/ # #??????????????????????????????????????????????????????????????????????????????????????????????????????%r??-o?K??7???=???D???????4???!???????????????????????W?? #D #2 # #??????????????????v????????????????????????????????????????????????????????????????????????????????p}??!q??6s?9~?\??:???????????%????????????????????????z??S?? #D #3 # #????????????????????????????????????????????????????????????????????????????????????????????????vx?m??s??7v?Fv?G??g??;???{????????????????????????{??r??P?? #D #3 # #????????????????????????????????????????????????????????????????????????????????????????????????or??m??u??a???Dx?Z??P??k??s?????????????????????}??t??l??M?? #D #3 # #????????????.?????????????????????????????????????????????????????????????????????????????????vx?i??o??w?????r???U??f??T??t??p??l??h??d??`??Z??V??R??M????? #D #3 # #?????????????????????????????????????????????????????????????????????????????????????????????mo??j??p??z???????????a??m???????????????????????m??Lz?w #J #H #> #. # #?????????S????????????????????????????????????????????ν???????????????????????????????????ux?h??j??r?????????? ???????k??~???????????????????i??m??Oz?t #? #3 #$ # #?????????׺???????????????????????????????????????????????????????????????????????????????jn??f??k?? u?? ????????? ???+???????x??z????????????????????z??j??W??l #& # # #???????????????????????????????????????????????????????????????????????????????????????tx?h??h??n??x?? ?????????!???/???8??????????????????????????????????????x???h??? #' # # #??????*???ѵ??????????????????????????????????ì??˷??????????????????????????????????g]|?i??h??q??{???????????$???4???@???????P???????-?????????????????????`?? #0 # # #??? #q\S؝????????????????????????????????????????????????????????????????????????uv?1??i??j??r??}?????Q?????$???2???F???????@???1????????????????????????Z?? #< #* # #??? #Q;0dq\S?Ӽ???????????????????????????????????????????????????????????????????im?0??k??m??t??}?????4??Q??!???4???G???????4???!???????????????????????W?? #C #1 # #??? V@5ȣ????????????????????????????????????????????????????????????????tu?+$&V2??m??p??x??|?????;??5??Z??8???P???????%????????????????????????z??S?? #D #3 # #??????w_Y?Կ???????????????????????????????????????????????????????????lo?"J3??p??q??w??}?????;??=??=??e??T???{????????????????????????{??r??P?? #D #3 # #?????? T?5??????????????????????????????????????????????????????????rr?,%'V"E5??q??r??w??z??~??Q???=??L??V??l??x??s??o??k??f??b??[??Z??V??R??@?? #D #3 # #?????????  s[U?ҿ??????????????????????;???????????????????????????km?OB3??t??u??w??z??~?????f???L??Y??a??z??r??t??}????????p??'??? #K #I #G #> #. # #????????? R=4?????????????????????????˼??????????????????ʻ???po?!kW1;Sa 4?? c??u??u??u??|????????r???[??b??i??p??v??}????????o??l?? #I #C #; #0 #" # #????????????  pZR?κ??????????????????ȹ???????????????????????hi?j]K-9S[6?? ^??s??w??|????????-???~???b??l??r??x??{??????????????q??Q??? #- # # # #????????????  M:1???~?ʻ??????????????Ŷ??????????????Ĵ???nm?vi[ I?%/CV7??Z??w??}????????6???M???????m??r??w??~?????????????????q?? #* # # # #???????????????  jLD?ɶ???ÿ??????????????Ŀ??¾??????????ef?mc T C:<"1U9??W??}????????:???[???v??????????????????????????????????????x???h??? #! # # #??????????????? P71g?b]?ó??̼??????????????̽???????lj?vi\ J<56=!O7~?vu?????wXU?{XU?mcR <+   # # # #1]??a??p?????????????????????}??t??l??M?? #D #3 # #???????????????????????????  hJCݤ???wTO?#xeU> '  # # # # # # #% # # # # # # # # # # # #) #7 #@ #D #D #D #D #D #D #D #D #= #. # #?????????????????????????????? lUO?7-.PE;%??? # # # # # # # # # # # # # #$ #. #2 #3 #3 #3 #3 #3 #3 #3 #. #" # #??????????????????????????????#"#$ +!&! # #?????? # # # # # # # # # # # # # # # # # # # # # # # # # # #????????????????????????????????? #! # # # #????????? # # # # # # # # # # # # # # # # # # # # # # # # # # #??????????????????????????????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?