Message-ID: <4893CBA9.9020008@cn.fujitsu.com>
Date: Sat, 02 Aug 2008 10:51:21 +0800
From: Yu Zhiguo <yuzg@cn.fujitsu.com>
User-Agent: Thunderbird 1.5.0.7 (Windows/20060909)
MIME-Version: 1.0
To: zhangxiliang <zhangxiliang@cn.fujitsu.com>
CC: Eric Paris <eparis@redhat.com>, Steve Grubb <sgrubb@redhat.com>,
       viro@zeniv.linux.org.uk, Linux Audit <linux-audit@redhat.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix the kernel panic of audit_filter_task when key field
 is set
References: <4892F063.1080109@cn.fujitsu.com> <4893C42A.60803@cn.fujitsu.com>
In-Reply-To: <4893C42A.60803@cn.fujitsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 838
Lines: 31


zhangxiliang wrote:

>  static int audit_match_perm(struct audit_context *ctx, int mask)
>  {
> +	if(!ctx)
> +		return 0;
>  	unsigned n = ctx->major;

Please check this patch with scripts/checkpatch.pl and then resend it.


>  	switch (audit_classify_syscall(ctx->arch, n)) {
>  	case 0:	/* native */
> @@ -284,6 +286,8 @@ static int audit_match_filetype(struct audit_context *ctx, int which)
>  {
>  	unsigned index = which & ~S_IFMT;
>  	mode_t mode = which & S_IFMT;
> +	if(!ctx)
> +		return 0;
>  	if (index >= ctx->name_count)
>  		return 0;
>  	if (ctx->names[index].ino == -1)
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/