Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755709AbYHBOcS (ORCPT ); Sat, 2 Aug 2008 10:32:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752562AbYHBOcB (ORCPT ); Sat, 2 Aug 2008 10:32:01 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:37122 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbYHBOcA (ORCPT ); Sat, 2 Aug 2008 10:32:00 -0400 From: "Rafael J. Wysocki" To: Matt Helsley Subject: Re: [PATCH 2/6] Container Freezer: Make refrigerator always available Date: Sat, 2 Aug 2008 16:34:45 +0200 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: Andrew Morton , Thomas Petazzoni , Paul Menage , Li Zefan , Linux-Kernel , Linux Containers , linux-pm@lists.linux-foundation.org, Cedric Le Goater , "Serge E. Hallyn" , Michael Opdenacker , linux-embedded@vger.kernel.org References: <20080801050659.924495279@us.ibm.com> <200808020053.18638.rjw@sisk.pl> <1217633074.25300.281.camel@localhost.localdomain> In-Reply-To: <1217633074.25300.281.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-7" Content-Disposition: inline Message-Id: <200808021634.46459.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha.home.local id m72EWMIG010864 Content-Length: 7917 Lines: 10 On Saturday, 2 of August 2008, Matt Helsley wrote:> > On Sat, 2008-08-02 at 00:53 +-0200, Rafael J. Wysocki wrote:> > On Friday, 1 of August 2008, Matt Helsley wrote:> > > > > > On Fri, 2008-08-01 at 16:27 +-0200, Thomas Petazzoni wrote:> > > > Hi,> > > > > > > > Le Thu, 31 Jul 2008 22:07:01 -0700,> > > > Matt Helsley a +AOk-crit :> > > > > > > > > --- a/kernel/Makefile> > > > > +-+-+- b/kernel/Makefile> > > > > @@ -5,7 +-5,7 @@> > > > > obj-y = sched.o fork.o exec_domain.o panic.o printk.o +AFw> > > > > cpu.o exit.o itimer.o time.o softirq.o resource.o +AFw> > > > > sysctl.o capability.o ptrace.o timer.o user.o +AFw> > > > > - signal.o sys.o kmod.o workqueue.o pid.o +AFw> > > > > +- signal.o sys.o kmod.o workqueue.o pid.o freezer.o +AFw> > > > > > > > I have the impression that the code in kernel/power/process.c was> > > > compiled only if CONFIG_PM_SLEEP was set. Now that the code has been> > > > moved to kernel/freezer.c, it is unconditionnaly compiled in every> > > > kernel. Is that correct ?> > > >> > > > If so, is it possible to put this new feature under some> > > > CONFIG_SOMETHING option, for people who care about the kernel size ?> > > > > > How about making it depend on a combination of CONFIG variables?> > > Here's an RFC PATCH. Completely untested.> > > > > > Signed-off-by: Matt Helsley > > > > Can you please also make the contents of include/linux/freezer.h depend on> > CONFIG_FREEZER instead of CONFIG_PM_SLEEP?> > Good point -- I'll add that to this patch and repost.> > > Also, I'm not really sure if kernel/power/Kconfig is the right place to define> > CONFIG_FREEZER.> > There's no nice place to put it since we're dealing with CONFIG_> variables in two different Kconfig files. I put it in> kernel/power/Kconfig because I wasn't certain Kbuild would do the right> thing if I referenced PM_SLEEP from init/Kconfig.> > > Perhaps we should even move freezer.c from kernel/power to kernel> > It's already there. Yes, sorry. > Perhaps you meant something else (kernel/power/process.c?)? Well, I'll have to actually apply the patches and look at the modified code. > > and define CONFIG_FREEZER in Kconfig in there. Andrew, what do you think?> > The Kconfig files in kernel/ are Kconfig.hz and Kconfig.preemt which> don't seem appropriate. I suppose we could add another (perhaps> Kconfig.cgroup). Either that, or Kconfig.freezer maybe? After all, it will also be used forPM_SLEEP, at least for some time. > Thanks for the review! You're welcome. Thanks,Rafael7mN???n?7mN?p4o0?gAp?????M??7mN? 5o?7mN???n?7mN?`5o?5o?p?????M??7mN??5o?7mN???n?7mN?P6op6oap?????M??7mN??6o?7mN???n?7mN?@7o`7o?p?????M??7mN??7o?7mN???n?7mN?08oP8o?p?????M??7mN?p8o?7mN???n?7mN? 9o@9op?????M??7mN?`9o?7mN???n?7mN?:o0:o?p?????M??7mN?P:o?7mN???n?7mN?;o ;o1p?????M??7mN?@;o?7mN???n?7mN??;oo?7mN???n?7mN??>o?>oqp?????M??7mN??o?7mN???n?7mN???o??op?????M??7mN???o?7mN???n?7mN??@o?@o?p?????M??7mN??@o?7mN???n?7mN??Ao?Ao!p?????M??7mN??Ao?7mN???n?7mN??Bo?Bo?p?????M??7mN??Bo?7mN???n?7mN?pCo?CoAp?????M??7mN??Co?7mN???n?7mN?`Do?Do? p?????M??7mN??Do?7mN???n?7mN?PEopEoa p?????M??7mN??Eo?7mN???n?7mN?@Fo`Fo? p?????M??7mN??Fo?7mN???n?7mN?0GoPGo? p?????M??7mN?pGo?7mN???n?7mN? Ho@Ho p?????M??7mN?`Ho?7mN???n?7mN?Io0Io? p?????M??7mN??4o?7mN???n?7mN??Io??g1 p?????M??7mN? Jo?7mN???n?7mN??Jo?Jo?p?????M??7mN??o?7mN???n?7mN??Ko?KoQp?????M??7mN?Lo?7mN???n?7mN??Lo?Lo? p?????M??7mN??Lo?7mN???n?7mN??Mo?Moq p?????M??7mN?pNo?7mN?@!o?7mN??Mo p?????M??7mN?@Oo?7mN?@!o?7mN??Oo?Oo?p?????M??7mN??Oo?7mN?@!o?7mN?pPo?Po!p?????M??7mN??Po?7mN?@!o?7mN?`Qo?Qo?p?????M??7mN??Qo?7mN?@!o?7mN?PRopRoAp?????M??7mN??Ro?7mN?@!o?7mN?@So`So?p?????M??7mN??So?7mN?@!o?7mN?0ToPToap?????M??7mN?pTo?7mN?@!o?7mN? Uo@Uo?p?????M??7mN?`Uo?7mN?@!o?7mN?Vo0Vo?p?????M??7mN?PVo?7mN?@!o?7mN?Wo Wop?????M??7mN?@Wo?7mN?@!o?7mN??WoXo?p?????M??7mN?0Xo?7mN?@!o?7mN??XoYo1p?????M??7mN? Yo?7mN?@!o?7mN??Yo?Yo?p?????M????7mN??No?7mN?@!o?7mN??Zo[oQp?????M?`??7mN??Zo?7mN?@!o?7mN??[o?[o?p?????M????7mN?\o?7mN?@!o?7mN??\o?\oqp?????M? ??7mN??\o?7mN?@!o?7mN??]o?]op?????M?@??7mN??]o?7mN?@!o?7mN??^o?^o?p?????M?`??7mN??^o?7mN?@!o?7mN??_o????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?