Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753220AbYHCBcZ (ORCPT ); Sat, 2 Aug 2008 21:32:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751555AbYHCBcR (ORCPT ); Sat, 2 Aug 2008 21:32:17 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:50152 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbYHCBcQ (ORCPT ); Sat, 2 Aug 2008 21:32:16 -0400 Date: Sat, 2 Aug 2008 19:32:00 -0600 From: Matthew Wilcox To: Simon Horman Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Luck , Keith Owens Subject: Re: [patch] IA64: suppress return value of down_trylock() in salinfo_work_to_do() Message-ID: <20080803013159.GB26461@parisc-linux.org> References: <20080803000654.GA30659@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080803000654.GA30659@verge.net.au> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 32 On Sun, Aug 03, 2008 at 10:06:58AM +1000, Simon Horman wrote: > salinfo_work_to_do() intentionally ignores the return value of > down_trylock() and calls up() regardless of if the lock > was taken or not. > > This patch suppresses the warning generated by ignoring > this return value - down_trylock() is annotated with __must_check. I can't say that I think this is a good idea. Has anyone looked at what it would take to actually track this? For example, could we ever have the situation where: task A acquires sem task B tries to acquire the sem, fails task B releases the sem that it didn't acquire task A releases the sem, falls down, goes boom? (of course, this is a semaphores, not a mutex, so it'll now be a counting semaphore with n=2, not protecting a damn thing). -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/