Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753754AbYHCEDg (ORCPT ); Sun, 3 Aug 2008 00:03:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751235AbYHCED2 (ORCPT ); Sun, 3 Aug 2008 00:03:28 -0400 Received: from saeurebad.de ([85.214.36.134]:59998 "EHLO saeurebad.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbYHCED1 (ORCPT ); Sun, 3 Aug 2008 00:03:27 -0400 From: Johannes Weiner To: Yinghai Lu Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "Eric W. Biederman" , Dhaval Giani , Mike Travis , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/25] add dyn_array support References: <1217732365-16595-1-git-send-email-yhlu.kernel@gmail.com> <1217732365-16595-2-git-send-email-yhlu.kernel@gmail.com> <1217732365-16595-3-git-send-email-yhlu.kernel@gmail.com> <1217732365-16595-4-git-send-email-yhlu.kernel@gmail.com> Date: Sun, 03 Aug 2008 06:03:03 +0200 In-Reply-To: <1217732365-16595-4-git-send-email-yhlu.kernel@gmail.com> (Yinghai Lu's message of "Sat, 2 Aug 2008 19:59:03 -0700") Message-ID: <871w163fuw.fsf@saeurebad.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1874 Lines: 69 Hi, Yinghai Lu writes: > could have crazy big arrays and allocate them in bootmem at init stage. > also also to allocate array according to size we need to use to avoid wasting > memory > use CONFIG_HAVE_DYN_ARRAY to enable it or not > > usage: > > |static struct irq_desc irq_desc_init __initdata = { > | .status = IRQ_DISABLED, > | .chip = &no_irq_chip, > | .handle_irq = handle_bad_irq, > | .depth = 1, > | .lock = __SPIN_LOCK_UNLOCKED(irq_desc->lock), > |#ifdef CONFIG_SMP > | .affinity = CPU_MASK_ALL > |#endif > |}; > | > |static void __init init_work(void *data) > |{ > | struct dyn_array *da = data; > | struct irq_desc *desc; > | int i; > | > | desc = *da->name; Where *da->name might be NULL... > | > | for (i = 0; i < *da->nr; i++) > | memcpy(&desc[i], &irq_desc_init, sizeof(struct irq_desc)); ... boom. > +void pre_alloc_dyn_array(void) > +{ > +#ifdef CONFIG_HAVE_DYN_ARRAY > + unsigned long size, phys = 0; > + struct dyn_array **daa; > + > + for (daa = __dyn_array_start ; daa < __dyn_array_end; daa++) { > + struct dyn_array *da = *daa; > + > + size = da->size * (*da->nr); > + print_fn_descriptor_symbol("dyna_array %s ", da->name); > + printk(KERN_CONT "size:%#lx nr:%d align:%#lx", > + da->size, *da->nr, da->align); > + *da->name = __alloc_bootmem_nopanic(size, da->align, phys); So, why is this _nopanic()? > + phys = virt_to_phys(*da->name); > + printk(KERN_CONT " ==> [%#lx - %#lx]\n", phys, phys + size); > + > + if (da->init_work) > + da->init_work(da); > + } > +#endif Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/