Date: Sun, 3 Aug 2008 19:27:52 +0200 (CEST)
From: Sven Wegener <sven.wegener@stealer.net>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
cc: LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>,
       Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH] ALSA: pcm_native: remove unused label
In-Reply-To: <20080803164719.GA5414@joi>
Message-ID: <alpine.LNX.1.10.0808031921280.7765@titan.stealer.net>
References: <20080803164719.GA5414@joi>
User-Agent: Alpine 1.10 (LNX 962 2008-03-14)
Organization: STEALER.net
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1350
Lines: 40

On Sun, 3 Aug 2008, Marcin Slusarz wrote:

> gcc warns about it:
> sound/core/pcm_native.c: In function 'snd_pcm_fasync':
> sound/core/pcm_native.c:3262: warning: label 'out' defined but not used
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
> ---
>  sound/core/pcm_native.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index c49b9d9..333cff6 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -3259,7 +3259,6 @@ static int snd_pcm_fasync(int fd, struct file * file, int on)
>  	runtime = substream->runtime;
>  
>  	err = fasync_helper(fd, file, on, &runtime->fasync);
> -out:
>  	unlock_kernel();
>  	if (err < 0)
>  		return err;

Uhm, no, there's

snd_assert(substream != NULL, goto out);

one line above your context. The snd_assert() macro will only include the 
second argument with CONFIG_SND_DEBUG, without CONFIG_SND_DEBUG it just 
evaulates the first parameter and triggers the warning.

Sven
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/