Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759511AbYHCVIF (ORCPT ); Sun, 3 Aug 2008 17:08:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756521AbYHCVHw (ORCPT ); Sun, 3 Aug 2008 17:07:52 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:33960 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755345AbYHCVHv (ORCPT ); Sun, 3 Aug 2008 17:07:51 -0400 Date: Sun, 03 Aug 2008 14:07:51 -0700 (PDT) Message-Id: <20080803.140751.57839905.davem@davemloft.net> To: sven.wegener@stealer.net Cc: marcin.slusarz@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, den@openvz.org Subject: Re: [PATCH] net: Add missing extra2 parameter for ip_default_ttl sysctl From: David Miller In-Reply-To: References: <1217793894.8154.38.camel@iris.sw.ru> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1840 Lines: 39 From: Sven Wegener Date: Sun, 3 Aug 2008 22:18:59 +0200 (CEST) > Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 acceses the extra2 parameter of > the ip_default_ttl ctl_table, but it is never set to a meaningful value. When > e84f84f276473dcc673f360e8ff3203148bdf0e2 is applied, we'll oops in > rt_cache_invalidate(). Set extra2 to init_net, to avoid that. > > Reported-by: Marcin Slusarz > Signed-off-by: Sven Wegener > Tested-by: Marcin Slusarz > Acked-by: Denis V. Lunev Applied, thanks a lot. Please provide commit header line text when referencing SHA IDs, as the SHA IDs can change when patches are applied to different trees. Here is the actual changelog message I used so you can see what I mean: net: Add missing extra2 parameter for ip_default_ttl sysctl Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 ("netns: add namespace parameter to rt_cache_flush") acceses the extra2 parameter of the ip_default_ttl ctl_table, but it is never set to a meaningful value. When e84f84f276473dcc673f360e8ff3203148bdf0e2 ("netns: place rt_genid into struct net") is applied, we'll oops in rt_cache_invalidate(). Set extra2 to init_net, to avoid that. Reported-by: Marcin Slusarz Signed-off-by: Sven Wegener Tested-by: Marcin Slusarz Acked-by: Denis V. Lunev Signed-off-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/