Subject: Re: [PATCH] iwlwifi: Don't use buffer allocated on the stack for
	led names
From: Zhu Yi <yi.zhu@intel.com>
To: Sven Wegener <sven.wegener@stealer.net>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
       linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
       Richard Purdie <rpurdie@rpsys.net>
In-Reply-To: <alpine.LNX.1.10.0808012143050.2294@titan.stealer.net>
References: <alpine.LNX.1.10.0808012143050.2294@titan.stealer.net>
Content-Type: text/plain
Organization: Intel Corp.
Date: Mon, 04 Aug 2008 11:39:30 +0800
Message-Id: <1217821170.3107.17.camel@debian.sh.intel.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1113
Lines: 32

On Fri, 2008-08-01 at 21:57 +0200, Sven Wegener wrote:
> Having the buffer on the stack and even re-using it for all led
> devices is bad.
> Not being able to resolve the name member of the led device structure
> to a
> meaningful value leads to confusion during ad-hoc debugging and
> potential
> breakage in the future, if we ever decide to access the name member
> outside of
> the registration function. Move the buffer to our private per led
> device
> structures so that it is accessible after registration.
> 
> A quick grep didn't yield any occurence of using the led device name
> parameter
> outside of the led device registration function, so currently we
> should already
> be safe for normal operation.
> 
> Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
> Cc: Richard Purdie <rpurdie@rpsys.net>

Acked-by: Zhu Yi <yi.zhu@intel.com>

Thanks,
-yi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/