Message-ID: <48969F99.1060301@movial.fi>
Date: Mon, 04 Aug 2008 09:20:09 +0300
From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Organization: Movial Creative Technologies
User-Agent: Icedove 1.5.0.14eol (X11/20080509)
MIME-Version: 1.0
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>, hpa <hpa@zytor.com>,
       tglx <tglx@linutronix.de>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] x86: Coding style fixes to arch/x86/lib/strstr_32.c
References: <20080802212445.72fb1d77@paolo-desktop>
In-Reply-To: <20080802212445.72fb1d77@paolo-desktop>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1506
Lines: 47

Paolo Ciarrocchi wrote:
> Before:
> total: 3 errors, 0 warnings, 31 lines checked
> 
> After:
> total: 0 errors, 0 warnings, 31 lines checked
> 
> paolo@paolo-desktop:~/linux.trees.git$ md5sum /tmp/strstr_32.o.*

It seems very tempting to merge this file with arch/x86/lib/string_32.c, or is there any compelling reason to keep these two separate?

> c96006ec3387862e5bacb139207a3098  /tmp/strstr_32.o.after
> c96006ec3387862e5bacb139207a3098  /tmp/strstr_32.o.before
> 
> Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
> ---
>  arch/x86/lib/strstr_32.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/lib/strstr_32.c b/arch/x86/lib/strstr_32.c
> index 42e8a50..8e2d55f 100644
> --- a/arch/x86/lib/strstr_32.c
> +++ b/arch/x86/lib/strstr_32.c
> @@ -23,9 +23,9 @@ __asm__ __volatile__(
>  	"jne 1b\n\t"
>  	"xorl %%eax,%%eax\n\t"
>  	"2:"
> -	:"=a" (__res), "=&c" (d0), "=&S" (d1)
> -	:"0" (0), "1" (0xffffffff), "2" (cs), "g" (ct)
> -	:"dx", "di");
> +	: "=a" (__res), "=&c" (d0), "=&S" (d1)
> +	: "0" (0), "1" (0xffffffff), "2" (cs), "g" (ct)
> +	: "dx", "di");
>  return __res;

It's strange that checkpatch.pl does not cater for such an obvious style violation as this last line.

Dmitri

>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/