Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756230AbYHDN0h (ORCPT ); Mon, 4 Aug 2008 09:26:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756962AbYHDN0U (ORCPT ); Mon, 4 Aug 2008 09:26:20 -0400 Received: from aun.it.uu.se ([130.238.12.36]:64007 "EHLO aun.it.uu.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756920AbYHDN0T (ORCPT ); Mon, 4 Aug 2008 09:26:19 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18583.883.70907.983634@harpo.it.uu.se> Date: Mon, 4 Aug 2008 15:26:11 +0200 From: Mikael Pettersson To: Arkadiusz Miskiewicz Cc: linux-kernel@vger.kernel.org Subject: Re: Opteron Rev E has a bug ... a locked instruction doesn't act as a read-acquire barrier In-Reply-To: <200808031106.12366.arekm@maven.pl> References: <200808031106.12366.arekm@maven.pl> X-Mailer: VM 7.17 under Emacs 20.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 36 Arkadiusz Miskiewicz writes: > > Hello, > > http://google-perftools.googlecode.com/svn-history/r48/trunk/src/base/atomicops-internals-x86.cc > says > > " // Opteron Rev E has a bug in which on very rare occasions a locked > // instruction doesn't act as a read-acquire barrier if followed by a > // non-locked read-modify-write instruction. Rev F has this bug in > // pre-release versions, but not in versions released to customers, > // so we test only for Rev E, which is family 15, model 32..63 inclusive. > if (strcmp(vendor, "AuthenticAMD") == 0 && // AMD > family == 15 && > 32 <= model && model <= 63) { > AtomicOps_Internalx86CPUFeatures.has_amd_lock_mb_bug = true; > } else { > AtomicOps_Internalx86CPUFeatures.has_amd_lock_mb_bug = false; > } > " > > does kernel have quirk/workaround for this? I'm looking at arch/x86/kernel/cpu > but I don't see workaround related to this (possibly I'm overlooking). I can find no reference to this alleged RevE erratum in the Athlon64/Opteron revision guide (25759.pdf). But if this bug is real then we need to know about it. Could you ask the author of the code you quoted above to clarify? /Mikael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/