Message-ID: <48970F8E.9010507@s5r6.in-berlin.de>
Date: Mon, 04 Aug 2008 16:17:50 +0200
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11
MIME-Version: 1.0
To: jmerkey@wolfmountaingroup.com
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.27-rc1 6/25] mdb:  Merkey's Kernel Debugger 2.6.27-rc1
References: <37445.166.70.238.45.1217831466.squirrel@webmail.wolfmountaingroup.com>
In-Reply-To: <37445.166.70.238.45.1217831466.squirrel@webmail.wolfmountaingroup.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1572
Lines: 57

jmerkey@wolfmountaingroup.com wrote:
> --- a/debug/mdb.c	1969-12-31 17:00:00.000000000 -0700
> +++ b/debug/mdb.c	2008-08-03 16:15:00.000000000 -0600
[...]
> +ULONG ScreenInputFromKeyboard(BYTE *buf, ULONG buf_index, ULONG max_index)
> +{
[...]
> +    HistoryIndex = HistoryPointer;
> +    while (1)
> +    {
> +       key = mdb_getkey();
> +
> +       if ((IsAccelerator(key)) && (key != 13))
> +	  return key;
> +
> +       switch (key)
> +       {
[...]
> +	  default:
> +	     if ((key > 0x7E) || (key < ' '))  // if above or below text
> +		break;
> +	     else
> +	     {
> +	        if (strlen(buf) < max_index)
> +		{
> +                   register int delta;
> +
> +		   for (i=max_index; i > buf_index; i--)
> +		      buf[i] = buf[i-1];
> +		   buf[buf_index] = (BYTE)key;
> +		   if (buf_index < max_index)
> +		      buf_index++;
> +
> +                   delta = strlen(buf) - buf_index;
> +
> +                   for (i=0; (i < delta) && (buf[i]); i++)
> +                        DBGPrint("%c", buf[buf_index + i]);
> +
> +                   for (i=0; i < delta; i++)
> +                        DBGPrint("\b");
> +		}
> +             }
> +	     break;
> +       }
> +    }
> +}

This function would benefit from being broken up into smaller ones.
-- 
Stefan Richter
-=====-==--- =--- --=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/