DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=nX8FYXuW+NK5Ngu/GfzefMYEfRCfatZdw+pPJCyKhxinRy86Xx/YCTpindk2y+nUAY
         S03Bn3ND4zSYMFcYkUASPsU4SjTswW8wVlGjTtLq9M64ct1zgtzW0086trqKIvMwbeBO
         Hc0RUK0QJRboJ8BUon8vVCqV2e3Sn8ovQyn88=
Message-ID: <40f323d00808041102s276c065fn8db6f5a79fdf7ad1@mail.gmail.com>
Date: Mon, 4 Aug 2008 20:02:37 +0200
From: "Benoit Boissinot" <bboissin@gmail.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API.
Cc: "Chris Mason" <chris.mason@oracle.com>, dwmw2@infradead.org,
       austin_zhang@linux.intel.com, davem@davemloft.net,
       linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
In-Reply-To: <E1KQ2D2-0003Fn-00@gondolin.me.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1217857537.29139.70.camel@think.oraclecorp.com>
	 <E1KQ2D2-0003Fn-00@gondolin.me.apana.org.au>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1441
Lines: 32

On Mon, Aug 4, 2008 at 5:42 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Chris Mason <chris.mason@oracle.com> wrote:
>>
>>>From a performance point of view I'm probably reading the crypto API
>> code wrong, but it looks like my choices are to either have a long
>> standing context and use locking around the digest/hash calls to protect
>> internal crypto state, or create a new context every time and take a
>> perf hit while crypto looks up the right module.
>
> You're looking at the old hash interface.  New users should use the
> ahash interface which was only recently added to the kernel.  It
> lets you store the state in the request object which you pass to
> the algorithm on every call.  This means that you only need one
> tfm in the entire system for crc32c.
>
> BTW, don't let the a in ahash intimidate you.  It's meant to support
> synchronous implementations such as the Intel instruction just as
> well as asynchronous ones.

Since I couldn't find any ahash user in the tree (outside of tcrypt.c), can you
provide some example source code as to how to use it (especially synchonously).

For example the code for the digest_null testing would be fine.

regards,

Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/