Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566AbYHDSTC (ORCPT ); Mon, 4 Aug 2008 14:19:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754494AbYHDSSM (ORCPT ); Mon, 4 Aug 2008 14:18:12 -0400 Received: from an-out-0708.google.com ([209.85.132.247]:42383 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754317AbYHDSNh (ORCPT ); Mon, 4 Aug 2008 14:13:37 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=Iqbrj7oC0hJXIne7QNBWObZ5Q4x2AtPq3nVBQElFNCmZreHsJGcFMOjyyLmOnTPZOE 27mxlHmcHY8BRDTAECY4JHnIXTDU7JO4goGuEZ7rMkVIXexxEuVtSxhkFlE1rfOXp48p GHcddBrEDjQe/8LT7RLVlxtqu9xifeYzAKnn0= Message-ID: <86802c440808041113i77ad39b6of5b84e36e6bed830@mail.gmail.com> Date: Mon, 4 Aug 2008 11:13:36 -0700 From: "Yinghai Lu" To: "Alan Cox" Subject: Re: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2 Cc: "Eric W. Biederman" , "Ingo Molnar" , "Thomas Gleixner" , "H. Peter Anvin" , "Dhaval Giani" , "Mike Travis" , "Andrew Morton" , linux-kernel@vger.kernel.org In-Reply-To: <20080804151734.0d82fbe9@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1217732365-16595-1-git-send-email-yhlu.kernel@gmail.com> <1217732365-16595-17-git-send-email-yhlu.kernel@gmail.com> <1217732365-16595-18-git-send-email-yhlu.kernel@gmail.com> <1217732365-16595-19-git-send-email-yhlu.kernel@gmail.com> <1217732365-16595-20-git-send-email-yhlu.kernel@gmail.com> <1217732365-16595-21-git-send-email-yhlu.kernel@gmail.com> <1217732365-16595-22-git-send-email-yhlu.kernel@gmail.com> <20080803161447.791705bb@lxorguk.ukuu.org.uk> <20080804151734.0d82fbe9@lxorguk.ukuu.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 32 On Mon, Aug 4, 2008 at 7:17 AM, Alan Cox wrote: >> Would allow us to use the generic hash table code. > > Nice.. that makes the code a bit longer in source form but much clearer > and sharing common design. > >> Looks like we can also tweak serial_do_unlink to free irq_info when >> the list goes empty, so we don't have a leak if the driver is ever >> unloaded. > > Like this (again not yet tested) > > 8250: Remove NR_IRQ usage > > From: Alan Cox > > > --- > > drivers/serial/68328serial.c | 11 +------ > drivers/serial/8250.c | 68 +++++++++++++++++++++++++++++++++--------- > 2 files changed, 56 insertions(+), 23 deletions(-) > thanks. will test it. YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/