Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759177AbYHDS1s (ORCPT ); Mon, 4 Aug 2008 14:27:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758744AbYHDS1U (ORCPT ); Mon, 4 Aug 2008 14:27:20 -0400 Received: from ti-out-0910.google.com ([209.85.142.185]:34950 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758726AbYHDS1R (ORCPT ); Mon, 4 Aug 2008 14:27:17 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:mime-version:content-type :content-transfer-encoding:content-disposition; b=QM8zKd40X7xG40sMcLBSTJ+6hBf/KbSwrbyLN1S8BtDFqX5sHfOmQ2R0yTQ5MdmvzB 2SszeCq4qUX3at6JOaGVxUbqv7ZyNMrwNbw1dRC8GYTeDFQEF1x4+Ky87/yFBzIgbCP1 rWefOFsJTUL/GAJO2ysJdikCxR8ZtfHHzBnGw= Message-ID: Date: Mon, 4 Aug 2008 23:57:15 +0530 From: "Manish Katiyar" To: kernel-janitors@vger.kernel.org, trivial@kernel.org, LKML Subject: [PATCH] Remove redundant condition from map_buffer_to_page Cc: mkatiyar@gmail.com MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 37 Currently the only caller to this function is do_mpage_readpage() which already checks if the buffer is uptodate, so a check inside is not required. Signed-off-by:- "Manish Katiyar" --- fs/mpage.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/mpage.c b/fs/mpage.c index dbcc7af..a797de1 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -135,8 +135,7 @@ map_buffer_to_page(struct page *page, struct buffer_head *bh, int page_block) * don't make any buffers if there is only one buffer on * the page and the page just needs to be set up to date */ - if (inode->i_blkbits == PAGE_CACHE_SHIFT && - buffer_uptodate(bh)) { + if (inode->i_blkbits == PAGE_CACHE_SHIFT) { SetPageUptodate(page); return; } -- 1.5.4.3 Thanks - Manish -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/