Date: Tue, 5 Aug 2008 10:27:49 +0200
From: Sebastien Dugue <sebastien.dugue@bull.net>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
       linux-rt-users@vger.kernel.org, paulus@samba.org,
       michael@ellerman.id.au, jean-pierre.dion@bull.net,
       gilles.carry@ext.bull.net, tinytim@us.ibm.com, tglx@linutronix.de,
       rostedt@goodmis.org
Subject: Re: [PATCH 1/3] powerpc - Initialize the irq radix tree earlier
Message-ID: <20080805102749.6ae24947@bull.net>
In-Reply-To: <1217898303.24157.122.camel@pasglop>
References: <1217848124-3719-1-git-send-email-sebastien.dugue@bull.net>
	<1217848124-3719-2-git-send-email-sebastien.dugue@bull.net>
	<1217898226.24157.120.camel@pasglop>
	<1217898303.24157.122.camel@pasglop>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1068
Lines: 31

On Tue, 05 Aug 2008 11:05:03 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> 
> >  - Remove the populating of the tree from the revmap function as
> >    you already do
> >  - Move it to irq_create_mapping() for the normal case
> >  - For pre-existing interrupt, have the generic code that initializes
> >    the radix tree walk through all interrupts and setup the revmap for
> >    them. If that needs locking vs. concurrent irq_create_mapping, it's
> >    easy to use one of the available spinlocks for that.
> 
> And in fact, you may even be able to avoid GFP_ATOMIC completely here
> and switch it to GFP_KERNEL since irq_create_mapping() can sleep afaik,
> provided that you avoid the spinlocking.

  Well, maybe, will have to look into this in details.

  Thanks,

  Sebastien.

> 
> Ben.
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/