Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758729AbYHEL3r (ORCPT ); Tue, 5 Aug 2008 07:29:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760357AbYHEL3h (ORCPT ); Tue, 5 Aug 2008 07:29:37 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:57202 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756337AbYHEL3f (ORCPT ); Tue, 5 Aug 2008 07:29:35 -0400 Date: Tue, 5 Aug 2008 05:28:14 -0600 From: Matthew Wilcox To: Simon Horman Cc: Sven Wegener , Michael Ellerman , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Jesse Barnes Subject: Re: [patch] PCI: check the return value of device_create_bin_file() in pci_create_bus() Message-ID: <20080805112814.GO26461@parisc-linux.org> References: <20080805101605.GA19382@verge.net.au> <1217932416.7758.4.camel@localhost> <20080805101605.GA19382@verge.net.au> <20080805110006.GA13409@verge.net.au> <20080805111406.GA13899@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080805111406.GA13899@verge.net.au> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 22 On Tue, Aug 05, 2008 at 09:14:07PM +1000, Simon Horman wrote: > Check the return value of device_create_bin_file in pci_create_bus, > unwind if necessary, and propagate any errors to the caller. Yes, but you're essentially saying here that if I can't create a couple of poxy sysfs files, I can't have this PCI bus at all? This seems like a bad decision to me. I'd rather have a PCI bus without the files than no PCI bus at all. By all means, we should whinge mightily if we can't create the files so the sysadmin has a chance of figuring out why things aren't quite working right, but I might have my root filesystem on a device on that PCI bus. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/