Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761900AbYHEM3p (ORCPT ); Tue, 5 Aug 2008 08:29:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756997AbYHEM3f (ORCPT ); Tue, 5 Aug 2008 08:29:35 -0400 Received: from mail0.lsil.com ([147.145.40.20]:44583 "EHLO mail0.lsil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755991AbYHEM3d convert rfc822-to-8bit (ORCPT ); Tue, 5 Aug 2008 08:29:33 -0400 From: "Yang, Bo" To: Andrew Morton CC: "'James.Bottomley@SteelEye.com'" , "'linux-scsi@vger.kernel.org'" , "'akpm@osdl.org'" , "'linux-kernel@vger.kernel.org'" , "Patro, Sumant" , "Austria, Winston" , "poswald@novell.com" Date: Tue, 5 Aug 2008 06:27:10 -0600 Subject: RE: [PATCH 1/4] scsi: megaraid_sas - Add the dumy readl to force PCI flush Thread-Topic: [PATCH 1/4] scsi: megaraid_sas - Add the dumy readl to force PCI flush Thread-Index: Acj2lAl3zUjjF7/dTTmVgOc+JmEIDQAYovZJ Message-ID: <4B6A08C587958942AA3002690DD4F8C31AADD4C1@cosmail02.lsi.com> References: <4B6A08C587958942AA3002690DD4F8C31B08093F@cosmail02.lsi.com>,<20080804174128.a0877c27.akpm@linux-foundation.org> In-Reply-To: <20080804174128.a0877c27.akpm@linux-foundation.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2248 Lines: 59 Thanks Andrew. Bo Yang ________________________________________ From: Andrew Morton [akpm@linux-foundation.org] Sent: Monday, August 04, 2008 8:41 PM To: Yang, Bo Cc: 'James.Bottomley@SteelEye.com'; 'linux-scsi@vger.kernel.org'; 'akpm@osdl.org'; 'linux-kernel@vger.kernel.org'; Patro, Sumant; Austria, Winston; poswald@novell.com Subject: Re: [PATCH 1/4] scsi: megaraid_sas - Add the dumy readl to force PCI flush On Fri, 1 Aug 2008 10:19:07 -0600 "Yang, Bo" wrote: > MegaRAID SAS Driver get unexpected Interrupt. Add the dumy readl to force PCI flush will fix this issue. > > Signed-off-by Bo Yang > > --- > drivers/scsi/megaraid/megaraid_sas.c | 6 ++++++ > 1 files changed, 6 insertions(+) > > diff -rupN linux-2.6.28_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.28_new/drivers/scsi/megaraid/megaraid_sas.c > --- linux-2.6.28_orig/drivers/scsi/megaraid/megaraid_sas.c 2008-07-31 12:00:58.000000000 -0400 > +++ linux-2.6.28_new/drivers/scsi/megaraid/megaraid_sas.c 2008-07-31 12:30:35.000000000 -0400 > @@ -198,6 +198,9 @@ megasas_clear_intr_xscale(struct megasas > */ > writel(status, ®s->outbound_intr_status); > > + /* Dummy readl to force pci flush */ > + readl(®s->outbound_intr_status); > + > return 0; > } > > @@ -293,6 +296,9 @@ megasas_clear_intr_ppc(struct megasas_re > */ > writel(status, ®s->outbound_doorbell_clear); > > + /* Dummy readl to force pci flush */ > + readl(®s->outbound_doorbell_clear); > + > return 0; > } > /** These patches all had their tabs replaced with spaces. I fixed them up. Please always run checkpatch on all patches. checkpatch found this: ERROR: Macros with complex values should be enclosed in parenthesis #182: FILE: drivers/scsi/megaraid/megaraid_sas.h:586: +#define MFI_GEN2_ENABLE_INTERRUPT_MASK 0x00000001 | 0x00000004 which is a potential source of bugs. I queued a patch to fix that also. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/