Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759107AbYHEO0s (ORCPT ); Tue, 5 Aug 2008 10:26:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757427AbYHEO0a (ORCPT ); Tue, 5 Aug 2008 10:26:30 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:44801 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756230AbYHEO02 (ORCPT ); Tue, 5 Aug 2008 10:26:28 -0400 Date: Tue, 5 Aug 2008 10:26:27 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Dasgupta, Romit" cc: "Rafael J. Wysocki" , David Engraf , Greg KH , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux-pm mailing list Subject: RE: [PATCH] [PM] Fixes missing PM entries in sysfs without CONFIG_PM_SLEEP In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 25 On Tue, 5 Aug 2008, Dasgupta, Romit wrote: > A minor change below: Removed old goto label PMError and introduced SysFSError. > Tested with CONFIG_PM, CONFIG_PM_SLEEP, without CONFIG_PM and ofcourse with CONFIG_USB_SUSPEND. Works fine. Strictly speaking, I suppose the statement label should be DPMSysfsError. On the other hand, the corresponding label for device_add_class_symlinks() is SymlinkError, not DeviceAddClassSymlinksError. The label for device_add_attrs() is AttrsError, not DeviceAddAttrsError. And the label for bus_add_device() is BusError, not BusAddDeviceError. Following those precedents, it seems appropriate that the label for dpm_sysfs_add() should be DPMError. I'll make the change and submit the patch. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/