Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761664AbYHEPnX (ORCPT ); Tue, 5 Aug 2008 11:43:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756692AbYHEPnL (ORCPT ); Tue, 5 Aug 2008 11:43:11 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:36684 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756460AbYHEPnJ (ORCPT ); Tue, 5 Aug 2008 11:43:09 -0400 From: Bjorn Helgaas To: James Bottomley Subject: Re: [PATCH 1/2] pci: add misrouted interrupt error handling Date: Tue, 5 Aug 2008 09:42:07 -0600 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: linux-scsi , linux-kernel , linux-pci@vger.kernel.org References: <1217786532.4179.24.camel@localhost.localdomain> <200808041443.20942.bjorn.helgaas@hp.com> <1217894547.3318.38.camel@localhost.localdomain> In-Reply-To: <1217894547.3318.38.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808050942.08123.bjorn.helgaas@hp.com> X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1476 Lines: 33 On Monday 04 August 2008 06:02:27 pm James Bottomley wrote: > On Mon, 2008-08-04 at 14:43 -0600, Bjorn Helgaas wrote: > > On Sunday 03 August 2008 12:02:12 pm James Bottomley wrote: > > > +static void pci_note_irq_problem(struct pci_dev *pdev, const char *reason) > > > +{ > > > + struct pci_dev *parent = to_pci_dev(pdev->dev.parent); > > > + > > > + dev_printk(KERN_ERR, &pdev->dev, > > > + "Potentially misrouted IRQ (Bridge %s %04x:%04x)\n", > > > + parent->dev.bus_id, parent->vendor, parent->device); > > > > Do you prefer "dev_printk(KERN_ERR, ...)" over "dev_err(...)"? Easier > > to grep for the former, maybe? If so, should we deprecate "dev_err()" > > and friends? When I converted most of the PCI core to use dev_printk(), > > (80ccba1186d48f ...) I used dev_err(), but I don't really care one way > > or the other. > > > > Maybe use pci_name(parent)? > > > > I tried to standardize the PCI core on "[%04x/%04x]" for vendor/device ID. > > To be honest I'm not really interested too much in the various API > preferences ... they can be fixed up later by the people who care. I'm happy to fix it up later if you prefer. I only mentioned it because doing it later adds churn and risk of breakage. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/