Subject: Re: [PATCH]: Fix MTRR handling on HT CPUs (improved)
To: Martin.Wilck@fujitsu-siemens.com (Martin Wilck)
Date: Fri, 25 Jan 2002 18:20:07 +0000 (GMT)
Cc: linux-kernel@vger.kernel.org (Linux Kernel mailing list),
        rgooch@atnf.csiro.au (Richard Gooch),
        Martin.Wilck@fujitsu-siemens.com (Martin Wilck),
        marcelo@conectiva.com.br (Marcelo Tosatti),
        torvalds@transmeta.com (Linus Torvalds)
In-Reply-To: <Pine.LNX.4.33.0201242145400.1046-100000@biker.pdb.fsc.net> from "Martin Wilck" at Jan 24, 2002 09:57:14 PM
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <E16UAxL-0003B6-00@the-village.bc.nu>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Sender: linux-kernel-owner@vger.kernel.org

> I strongly suspected somebody else must have hit this problem before, but
> intensive research did show up nothing. Also my first post on LK
> received no "hey, that's old stuff" answer. So here I go.

A tiny patch was posted about 4-6 months ago

The patch is total overkill. Just remove the error reporting if the right
firmware was already loaded. You've written a fixup wrapper around a 
rather nonsensical erorr check for an existing non-error.

The same will occur with CPU hot plugging in the future as well as ACPI
power saving sometimes and in those cases the patch you posted doesn't
help anyway.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/