Subject: Re: [PATCH 1/2] pci: add misrouted interrupt error handling
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
       linux-kernel <linux-kernel@vger.kernel.org>, linux-pci@vger.kernel.org
In-Reply-To: <200808051415.59993.jbarnes@virtuousgeek.org>
References: <1217786532.4179.24.camel@localhost.localdomain>
	 <200808051353.52323.jbarnes@virtuousgeek.org>
	 <1217969794.9923.70.camel@localhost.localdomain>
	 <200808051415.59993.jbarnes@virtuousgeek.org>
Content-Type: text/plain
Date: Tue, 05 Aug 2008 14:54:56 -0700
Message-Id: <1217973297.9923.80.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 4113
Lines: 85

On Tue, 2008-08-05 at 14:15 -0700, Jesse Barnes wrote:
> On Tuesday, August 05, 2008 1:56 pm James Bottomley wrote:
> > On Tue, 2008-08-05 at 13:53 -0700, Jesse Barnes wrote:
> > > On Tuesday, August 05, 2008 1:44 pm James Bottomley wrote:
> > > > On Tue, 2008-08-05 at 10:03 -0700, Jesse Barnes wrote:
> > > > > This seems to be a function that just returns what type of IRQ you're
> > > > > using or how it's routed and it isn't necessarily "lost interrupt"
> > > > > specific.
> > > >
> > > > So perhaps this routine should only note but not advise?  The drivers
> > > > can then just call pci_interrupt_type to see if they can do anything.
> > >
> > > If it's just a pci_irq_type function then it probably shouldn't print
> > > anything, and leave that to the caller, since it might be used for other
> > > purposes too (e.g. a driver load printk or something).  In the lost
> > > interrupt case you already have to disable MSI or MSIX in the Fusion
> > > driver, so you may as well put the printk there, right?  I guess I'm
> > > saying it should neither note nor advise, just return the IRQ type.
> >
> > Well, no; the object was to have the layer that knew (PCI) print
> > information which could be used to identify the problem.  Likely what
> > the driver will say is something like "MSI isn't working and it's not my
> > fault".  What I want is for PCI to print something that may be helpful
> > to people trying to diagnose the problem.  Driver writers aren't going
> > to get that right.
> 
> Yeah, I understand what you're trying to do, and given that there's only one 
> user of this function (your fusion patch), I don't have a strong preference.
> 
> However, the function is really just telling the driver what type of IRQ a 
> given PCI device currently has; it's not really a "lost interrupt" function 
> at all.  So to me, it makes sense to just generalize it into a pci_irq_type 
> function and let drivers do what they will with it.  It looks like this is 
> the real lost interrupt detection:
> 
> +               /* May fail becuase of IRQ misrouting */
> +               rc = mpt_get_manufacturing_pg_0(ioc);
> +               if (rc) {
> +			...
> +                       printk(MYIOC_s_ERR_FMT "Cannot recover IRQ routing\n",
> +                              ioc->name);
> +                       return -1;
> +               }
> 
> not the pci_lost_interrupt() function.  So it could just as easily be written 
> as such:
> 
> +               /* May fail becuase of IRQ misrouting */
> +               rc = mpt_get_manufacturing_pg_0(ioc);
> +               if (rc) {
> +			/* Lost an IRQ, see what type... */
> +			int irq_type = pci_irq_type(dev);
> +
> +                       if (type == PCI_IRQ_MSI) {
> +				/* Lost an MSI interrupt, try re-config w/o MSI */
> +                               free_irq(ioc->pci_irq, ioc);
> +                               ioc->msi_enable = 0;
> +                               pci_disable_msi(ioc->pcidev);
> +                               goto retry;
> +                       }
> +			/* This platform is just broken... */
> +                       printk(MYIOC_s_ERR_FMT "Cannot recover from %s IRQ
> +			       routing error\n", pci_irq_type_name(type), ioc->name);
> +                       return -1;
> +               }
> 
> or somesuch.  That seems just as simple for driver writers as your initial 
> patch, and the function is named in accordance with what it actually does, 
> rather than what it's used for...

It could, but if the bridge is the culprit (as it usually is for MSI
problems), this print won't help identify it.

Therefore, rather than give driver writers a recipe for "print this and
this and go to the bridge and print this", I'd rather have a single PCI
callback that prints all the (hopefully) relevant information that will
allow either fixing or blacklisting.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/