Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763649AbYHEWAI (ORCPT ); Tue, 5 Aug 2008 18:00:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755924AbYHEV7j (ORCPT ); Tue, 5 Aug 2008 17:59:39 -0400 Received: from toronto-hs-216-138-233-67.s-ip.magma.ca ([216.138.233.67]:35908 "HELO yow.seanm.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755074AbYHEV7i (ORCPT ); Tue, 5 Aug 2008 17:59:38 -0400 Date: Tue, 5 Aug 2008 17:59:37 -0400 From: Sean MacLennan To: "Linus Torvalds" Cc: "Karsten Keil" , "Benjamin Herrenschmidt" , "Andreas.Eversberg" , , Subject: Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti Message-ID: <20080805175937.49a5ba32@lappy.seanm.ca> In-Reply-To: References: <20080802151532.DE017A3C09@pingi.kke.suse.de> <1217910588.24157.151.camel@pasglop> <20080805113111.GA6827@pingi.kke.suse.de> <1217941466.24157.190.camel@pasglop> <20080805172549.GA6052@pingi.kke.suse.de> <20080805210239.GB6052@pingi.kke.suse.de> <20080805172324.45853d98@lappy.seanm.ca> Organization: PIKA X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.9; i686-pc-linux-gnu) X-Message-Flag: Warning: This message may contain actual content. Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 27 On Tue, 5 Aug 2008 14:37:19 -0700 (PDT) "Linus Torvalds" wrote: > On Tue, 5 Aug 2008, Sean MacLennan wrote: > > > > Why not select PIO or MMIO at config time? > > Umm. Then you can't run a generic driver that can do either. That's > the worst choice of all. But do we really need a generic driver that can do either? Maybe for the current mISDN driver, but when you get to other chip ports, say the xhfc, you have to select the low level interface at compile time. Or I should say you currently have to select at config time. I'm not arguing that we *have* to do it this way. I just don't think we should throw out the simplest method without some thought. There is some precedence for a config time option, for example the 8139too ethernet driver. Cheers, Sean -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/