From: "Woodruff, Richard" <r-woodruff2@ti.com>
To: "Wei, Gang" <gang.wei@intel.com>,
       Linux Power Management List <linux-pm@lists.osdl.org>
CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date: Tue, 5 Aug 2008 20:24:44 -0500
Subject: RE: [linux-pm] [RFC-PATCH] Improve Menu Governor Prediction of
 interrupted C states.
Thread-Topic: [linux-pm] [RFC-PATCH] Improve Menu Governor Prediction of
 interrupted C states.
Thread-Index: Acjl9NwKQ0on4gDvSK+0rYSuOpnIRwFzHyfwAuhi8pA=
Message-ID: <13B9B4C6EF24D648824FF11BE89671620361F4E439@dlee02.ent.ti.com>
References: <13B9B4C6EF24D648824FF11BE8967162035BEA0EDF@dlee02.ent.ti.com>
 <094BCE01AFBE9646AF220B0B3F367AAB034DBB7A@pdsmsx413.ccr.corp.intel.com>
In-Reply-To: <094BCE01AFBE9646AF220B0B3F367AAB034DBB7A@pdsmsx413.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1063
Lines: 26

Hi,

> I also found current cpuidle Menu governor should have some problems
> while predicting next non-expected break-event after some expected
> break-events. The measured_us/elapsed_us/predicted_us will become
> larger
> and larger once (measured_us + BREAK_FUZZ >= data->expected_us -
> target->exit_latency). The major point is that it should be
> last_residency, not measured_us, that need to be used to do comparing
> and distinguish between expected & non-expected events.
>
> Below is my draft patch (not tested) for this. It is simple and should
> also be effective for high interrupt rates case.

This does seem to give better guesses.  However, first tests are not showing as well as the irq time stamp version I posted.

I'll need to grab some hardware trace to see what is going on.

Thanks,
Richard W.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/