Message-ID: <48995D9F.4010900@s5r6.in-berlin.de>
Date: Wed, 06 Aug 2008 10:15:27 +0200
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.16) Gecko/20080722 SeaMonkey/1.1.11
MIME-Version: 1.0
To: jmerkey@wolfmountaingroup.com
CC: Masami Hiramatsu <mhiramat@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.27-rc1-git5 2/26] mdb: correct kprobes int3 trap
References: <200808050626.m756QZ1g003755@wolfmountaingroup.com>    <489872C5.2040508@redhat.com> <39379.166.70.238.45.1217950104.squirrel@webmail.wolfmountaingroup.com>
In-Reply-To: <39379.166.70.238.45.1217950104.squirrel@webmail.wolfmountaingroup.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1140
Lines: 24

jmerkey@wolfmountaingroup.com wrote on 2008-08-05:
> I was unaware of checkpatch.pl, but will run it later today and submit a
> git6 patch for any areas not in compliance with linux coding standards.

I guess you got complaints from scripts/checkpatch.pl for at least 3/4 
of all lines by now.  Some or many of the complaints will probably look 
silly.  Have a look at Documentation/CodingStyle then because it gives 
context for many of the complaints.  It also gives some rules of thumb 
for things which checkpatch.pl cannot check, e.g. legibility of global 
names.

 From what I saw, there are _many_ whitespace "deviations" in your code 
(which perhaps scripts/Lindent can help to adjust), upper case vs. lower 
case in names, and occasional functions which are deeper nested than 
probably necessary, as already mentioned.
-- 
Stefan Richter
-=====-==--- =--- --==-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/