Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755397AbYHFODn (ORCPT ); Wed, 6 Aug 2008 10:03:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752296AbYHFODe (ORCPT ); Wed, 6 Aug 2008 10:03:34 -0400 Received: from yw-out-2324.google.com ([74.125.46.29]:12477 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752267AbYHFODe convert rfc822-to-8bit (ORCPT ); Wed, 6 Aug 2008 10:03:34 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:reply-to:to:subject:cc:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:references; b=KzW76COSr1t0TxgS5QXSSylIZnNBVQK6PL/wb26DqJRFv7Ii2zZ+uig3KPU/6cPL3m JNxhWS8oeQAa0mVLjIFz4il+5fG8Gh5Sjwtx6yXn+OpQpJkshMqjNzHQLGooObwIdG6F lxD7flpS8Mg7LtTeelxzWBI7ERLQ0AlWDT0Eo= Message-ID: <9ea470500808060703p4a94c868i25106e081aad75c4@mail.gmail.com> Date: Wed, 6 Aug 2008 16:03:32 +0200 From: "Boris Petkov" Reply-To: petkovbb@gmail.com To: "Sergei Shtylyov" Subject: Re: [PATCH 1/2] pata_legacy: export functionality to ide Cc: "Bartlomiej Zolnierkiewicz" , "Alan Cox" , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org In-Reply-To: <48998C58.20703@ru.mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <20080802183253.GA2239@gollum.tnic> <20080803125907.67676948@lxorguk.ukuu.org.uk> <20080803143837.GA26672@gollum.tnic> <20080803162214.394b13a1@lxorguk.ukuu.org.uk> <20080803165135.GA31977@gollum.tnic> <4898630C.7090403@ru.mvista.com> <9ea470500808050732s7be29360ge358790e955be06a@mail.gmail.com> <58cb370e0808050741v7ff3f20awb3d91a84486f8547@mail.gmail.com> <20080806061023.GA23773@gollum.tnic> <48998C58.20703@ru.mvista.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2357 Lines: 70 On Wed, Aug 6, 2008 at 1:34 PM, Sergei Shtylyov wrote: > Hello. > > Borislav Petkov wrote: >> >> From: Borislav Petkov >> Date: Sun, 3 Aug 2008 18:46:35 +0200 >> Subject: [PATCH] ide-generic: handle probing of legacy io-ports v4 >> >> Avoid probing the io-ports in case an IDE PCI controller is present and it >> uses >> the legacy iobases. If we still want to enforce the probing, we do >> >> ide_generic.probe_mask=0x3f >> >> on the kernel command line. The iobase checking code is adapted from >> drivers/ata/pata_legacy.c after converting hex pci ids into their >> corresponding >> macros in . >> >> CC: Sergei Shtylyov >> Signed-off-by: Borislav Petkov >> > > Acked-by: Sergei Shtylyov > >> diff --git a/drivers/ide/ide-generic.c b/drivers/ide/ide-generic.c >> index 8fe8b5b..efce159 100644 >> --- a/drivers/ide/ide-generic.c >> +++ b/drivers/ide/ide-generic.c >> > > [...] >> >> @@ -100,19 +101,69 @@ static const u16 legacy_bases[] = { 0x1f0, 0x170, >> 0x1e8, 0x168, 0x1e0, 0x160 }; >> static const int legacy_irqs[] = { 14, 15, 11, 10, 8, 12 }; >> #endif >> +static void ide_generic_check_pci_legacy_iobases(int *primary, int >> *secondary) >> +{ >> + struct pci_dev *p = NULL; >> + u16 val; >> + >> + for_each_pci_dev(p) { >> + int r; >> + >> + for (r = 0; r < 6; r++) { >> + if (pci_resource_start(p, r) == 0x1f0) >> + *primary = 1; >> + if (pci_resource_start(p, r) == 0x170) >> + *secondary = 1; >> + } >> > > Would have been probably enough to test only BAR0/2, don't you think? I assume you're referring to the legacy ioports fixup in drivers/pci/probe.c:pci_setup_device(). Yes, there's no need to go all the way to BAR5 since those are guaranteed unused in compatibility mode, so actually the loop should go till 4. Bart, can you please change that when applying? -- Regards/Gru?, Boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/