Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760691AbYHFQxj (ORCPT ); Wed, 6 Aug 2008 12:53:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755557AbYHFQxK (ORCPT ); Wed, 6 Aug 2008 12:53:10 -0400 Received: from accolon.hansenpartnership.com ([76.243.235.52]:52736 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752601AbYHFQxG (ORCPT ); Wed, 6 Aug 2008 12:53:06 -0400 Subject: Re: [PATCH][SCS] sd: Read Capacity if (16) fails From: James Bottomley To: Hugh Dickins Cc: "Martin K. Petersen" , Andrew Morton , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <1218040613.7493.13.camel@localhost.localdomain> References: <1218040613.7493.13.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 06 Aug 2008 09:53:02 -0700 Message-Id: <1218041582.7493.19.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 36 On Wed, 2008-08-06 at 09:36 -0700, James Bottomley wrote: > On Wed, 2008-08-06 at 16:34 +0100, Hugh Dickins wrote: > > PQual=0 Device_type=0 RMB=1 version=0x00 [no conformance > > claimed] > > We could try using this as the trigger. I assume all DIF supporting > devices must also claim conformance to SPC3/SBC2 or higher? Just to formalise it, that would be this patch. Hugh, could you try it? Thanks, James --- diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 291d56a..ffbc84a 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -426,7 +426,7 @@ static inline int scsi_device_enclosure(struct scsi_device *sdev) static inline int scsi_device_protection(struct scsi_device *sdev) { - return sdev->inquiry[5] & (1<<0); + return sdev->scsi_level > SCSI_2 && sdev->inquiry[5] & (1<<0); } #define MODULE_ALIAS_SCSI_DEVICE(type) \ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/