Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030277AbYHFUP4 (ORCPT ); Wed, 6 Aug 2008 16:15:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760654AbYHFUOu (ORCPT ); Wed, 6 Aug 2008 16:14:50 -0400 Received: from ns2.suse.de ([195.135.220.15]:50603 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758236AbYHFUOs (ORCPT ); Wed, 6 Aug 2008 16:14:48 -0400 Date: Wed, 6 Aug 2008 13:07:21 -0700 From: Greg KH To: Martin Schwidefsky Cc: Kay Sievers , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, lf_kernel_messages@lists.linux-foundation.org, Andrew Morton , Michael Holzheu , Gerrit Huizenga , Randy Dunlap , Jan Kara , Pavel Machek , Sam Ravnborg , Joe Perches , Jochen =?iso-8859-1?B?Vm/f?= , Kunai Takashi , Tim Bird Subject: Re: [patch 1/3] kmsg: Kernel message catalog macros. Message-ID: <20080806200721.GA30086@suse.de> References: <20080730165656.118280544@de.ibm.com> <20080730171156.824640459@de.ibm.com> <3ae72650807301502h3e54e80yb405af7192048b89@mail.gmail.com> <20080730220432.GA24800@suse.de> <1217495404.8555.20.camel@localhost> <20080805223117.GA6552@suse.de> <1218011716.20769.12.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1218011716.20769.12.camel@localhost> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1979 Lines: 42 On Wed, Aug 06, 2008 at 10:35:16AM +0200, Martin Schwidefsky wrote: > On Tue, 2008-08-05 at 15:31 -0700, Greg KH wrote: > > On Thu, Jul 31, 2008 at 11:10:04AM +0200, Martin Schwidefsky wrote: > > > On Wed, 2008-07-30 at 15:04 -0700, Greg KH wrote: > > > > On Thu, Jul 31, 2008 at 12:02:04AM +0200, Kay Sievers wrote: > > > > > On Wed, Jul 30, 2008 at 18:56, Martin Schwidefsky > > > > > wrote: > > > > > > > > > > > +#define kmsg_dev_alert(id, dev, format, arg...) \ > > > > > > + printk(__KMSG_CHECK(ALERT, id) KMSG_COMPONENT \ > > > > > > + ": %s: " format, (dev)->bus_id , ## arg) > > > > > > > > > > Care to use dev_name(), bus_id will be removed soon. > > > > > > > > Hm, just use dev_printk() instead, it handles all of these kinds of > > > > changes automatically. > > > > > > Using dev_printk won't work because of the order of the elements of the > > > printk. The kmsg tag should not have a "random" position in the printk > > > but should be the first element. If we use dev_printk the kmsg tag will > > > be the third element, for other kmsg printks it will be the first. In > > > addition the kmsg message tag for the device drivers already includes > > > the driver name .. > > > > But the structure of dev_printk() is well definied and should be pretty > > trival to parse even with missing fields. > > The missing field is the message tag. Which is the key for the message > lookup. As far as the kmsg catalog is concerned this is a pretty > important field that may not be missing from the printk itself. No, I mean use dev_printk() as the base for your logging macro. Add your message tag as the first field after the dev_printk() information. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/