Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760109AbYHFUW4 (ORCPT ); Wed, 6 Aug 2008 16:22:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758498AbYHFUWn (ORCPT ); Wed, 6 Aug 2008 16:22:43 -0400 Received: from relay2.sgi.com ([192.48.171.30]:36745 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758315AbYHFUWn (ORCPT ); Wed, 6 Aug 2008 16:22:43 -0400 Date: Wed, 6 Aug 2008 15:22:41 -0500 From: Paul Jackson To: "Rakib Mullick" Cc: menage@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuset.c : Removes extra variable Message-Id: <20080806152241.387e765d.pj@sgi.com> In-Reply-To: References: Organization: SGI X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.12.0; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 25 Rabik wrote: > removes ... cpus_nonempty variable No. Sorry - I must NAQ this patch. I intentionally add inessential variables such as this in order to make the code easier to read. I consider the line of code: if (cpus_nonempty && balance_flag_changed) to be more readable than the line of clde: if (!cpus_empty(trialcs.cpus_allowed) && balance_flag_changed) -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.940.382.4214 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/