Date: Wed, 06 Aug 2008 20:20:38 -0700 (PDT)
Message-Id: <20080806.202038.93643856.davem@davemloft.net>
To: guijianfeng@cn.fujitsu.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Add (struct sock*) sk parameter for send_ack()
From: David Miller <davem@davemloft.net>
In-Reply-To: <48981BDE.70201@cn.fujitsu.com>
References: <48981BDE.70201@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 835
Lines: 25

From: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Date: Tue, 05 Aug 2008 17:22:38 +0800

> Add (struct sock*) sk parameter for send_ack.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>

This patch by itself breaks the build.

Don't submit patches this way.  Every patch applied should
still leave the tree building.

Also, since your OOPS and detailed description only exists
in the "0/3" email, it won't make it into the commit log
history where it belongs.

Considering all of this, I'd say you should fix this as
one big patch with a really nice commit log message.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/