Message-ID: <17163.166.70.238.44.1218131573.squirrel@webmail.wolfmountaingroup.com>
In-Reply-To: <489B31FE.5050302@s5r6.in-berlin.de>
References: <1300.69.2.248.210.1218119365.squirrel@webmail.wolfmountaingroup.com>  
        <489B199B.40305@s5r6.in-berlin.de>      
    <489B1BDC.1010504@s5r6.in-berlin.de>   
    <1923.69.2.248.210.1218124570.squirrel@webmail.wolfmountaingroup.com>  
     <489B26F0.3030603@s5r6.in-berlin.de>
    <1905.69.2.248.210.1218126817.squirrel@webmail.wolfmountaingroup.com>
    <489B2EAE.8040901@s5r6.in-berlin.de>
    <489B31FE.5050302@s5r6.in-berlin.de>
Date: Thu, 7 Aug 2008 11:52:53 -0600 (MDT)
Subject: Re: [ANNOUNCE] mdb-2.6.27-rc2-ia32-08-07-08.patch
From: jmerkey@wolfmountaingroup.com
To: "Stefan Richter" <stefanr@s5r6.in-berlin.de>
Cc: jmerkey@wolfmountaingroup.com, linux-kernel@vger.kernel.org
User-Agent: SquirrelMail/1.4.6
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 869
Lines: 28

> I wrote:
>> jmerkey@wolfmountaingroup.com wrote:
>>> check mdb-main.c -- I disable preemption before rspin_lock is
>>> attempted.
> ...
>> Then it is recommendable that you document the call context requirements
>> at the functions.
>
> An alternative would of course be to establish the non-preemptible
> context from inside the lock accessors, either redundantly to what the
> call site is doing, or instead of doing it at the call site if that can
> be arranged.
> --
> Stefan Richter
> -=====-==--- =--- --===
> http://arcgraph.de/sr/
>

It needs to get turned off right away, well before we get to the locks.

Keff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/