Return-Path: <linux-kernel-owner+w=401wt.eu-S1757572AbYHGVkd@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757572AbYHGVkd (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Aug 2008 17:40:33 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751739AbYHGVkS
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 7 Aug 2008 17:40:18 -0400
Received: from ogre.sisk.pl ([217.79.144.158]:36860 "EHLO ogre.sisk.pl"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752580AbYHGVkQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Aug 2008 17:40:16 -0400
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Ben Collins <ben.collins@canonical.com>
Subject: Re: [PATCH 6/7] pm: Config option to disable handling of console during suspend/resume
Date: Thu, 7 Aug 2008 23:43:07 +0200
User-Agent: KMail/1.9.6 (enterprise 20070904.708012)
Cc: Pavel Machek <pavel@suse.cz>, Greg KH <greg@kroah.com>,
       linux-kernel@vger.kernel.org,
       pm list <linux-pm@lists.linux-foundation.org>
References: <24762.90.138.930.038.1036103001.ben.collins@canonical.com> <20080804062823.GA22015@atrey.karlin.mff.cuni.cz> <1218144198.10040.196.camel@cunning>
In-Reply-To: <1218144198.10040.196.camel@cunning>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200808072343.08570.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1830
Lines: 46

On Thursday, 7 of August 2008, Ben Collins wrote:
> On Mon, 2008-08-04 at 08:28 +0200, Pavel Machek wrote:
> > Hi!
> > 
> > > > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> > > > > index e7bea3e..6a042f8 100644
> > > > > --- a/Documentation/kernel-parameters.txt
> > > > > +++ b/Documentation/kernel-parameters.txt
> > > > > @@ -2247,6 +2247,11 @@ and is between 256 and 4096 characters. It is defined in the file
> > > > >  	vmpoff=		[KNL,S390] Perform z/VM CP command after power off.
> > > > >  			Format: <command>
> > > > >  
> > > > > +	vt_switch=	[PM] Switch vt's during suspend/resume
> > > > > +			Format: { 0 | 1 }
> > > > > +			Default is normally '1', but depends on value of
> > > > > +			the PM_DISABLE_CONSOLE config option.
> > > > > +
> > > > 
> > > > Why a build time config option?  Why not just set the command line
> > > > option if you need this?  And/or make it a sysctrl?
> > > > 
> > > > That way we don't have to add yet-another-config-option for distros and
> > > > users to get wrong.
> > > > 
> > > > thanks,
> > > 
> > > Sysctl makes sense. I would rather not have to add a cmdline option to
> > > default installs (and on upgrades). I'll redo the patch that way and
> > > resend.
> > 
> > Maybe have acpi_sleep=no_vt_switch? THat is already settable from
> > userspace...?
> 
> Where is this setting?

This is a command line option + sysctl, but it won't be sufficient, IMO,
because it only is available on ACPI systems, while your sysctl should be
available on all systems that can suspend.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/