Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756042AbYHHBVa (ORCPT ); Thu, 7 Aug 2008 21:21:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752120AbYHHBVW (ORCPT ); Thu, 7 Aug 2008 21:21:22 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:55831 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbYHHBVV (ORCPT ); Thu, 7 Aug 2008 21:21:21 -0400 Date: Thu, 7 Aug 2008 21:21:18 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Roland McGrath cc: Jeremy Fitzhardinge , linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Andrew Morton , Linus Torvalds , David Miller , Mathieu Desnoyers , Ulrich Drepper , Rusty Russell , Gregory Haskins , Arnaldo Carvalho de Melo , "Luis Claudio R. Goncalves" , Clark Williams , Sam Ravnborg , "Eric W. Biederman" Subject: Re: [PATCH 0/5] ftrace: to kill a daemon In-Reply-To: <20080807222642.761AF15429D@magilla.localdomain> Message-ID: References: <20080807182013.984175558@goodmis.org> <489B6511.7000208@goop.org> <20080807222642.761AF15429D@magilla.localdomain> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1520 Lines: 35 On Thu, 7 Aug 2008, Roland McGrath wrote: > > This doesn't seem any less complex than what I did. With this, I would > > have to come up with another way to handle modules. This will make > > things a lot more complex. > > The scheme you've implemented can apply fine to a .ko file after it's made. > They are just .o's really. It is presumably faster to do one step per > final .ko rather than many tiny ones (per source file). > > That might be a benefit to doing it all at the end for vmlinux too. I > think the best way would be to have a vmlinux.o that we actually use in the > link, rather than just analyzing and discarding. Then you can just do your > existing hack on vmlinux.o before it's linked into vmlinux. OK, I am playing with this. And you are right, it does work with vmlinux.o file. It adds almost another minute to the build anytime something is changed. Where the per-object way may take longer doing a full build, but does not add that extra minute ever build. Which would people prefer? I little longer full build and do the modification on every object, or have a shorter full build, but every build will take that extra minute to do? Note, if you have DYNMAIC_FTRACE disabled, this is a nop, and will _not_ affect you. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/