Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756996AbYHHCLR (ORCPT ); Thu, 7 Aug 2008 22:11:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754458AbYHHCLG (ORCPT ); Thu, 7 Aug 2008 22:11:06 -0400 Received: from gir.skynet.ie ([193.1.99.77]:54860 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753781AbYHHCLF (ORCPT ); Thu, 7 Aug 2008 22:11:05 -0400 Date: Fri, 8 Aug 2008 03:11:03 +0100 (IST) From: Dave Airlie X-X-Sender: airlied@skynet.skynet.ie To: Randy Dunlap cc: lkml , akpm Subject: Re: [PATCH -next] drm: sis depends on FB_SIS In-Reply-To: <20080807175552.67d5385d.randy.dunlap@oracle.com> Message-ID: References: <20080807083228.0fc40405.randy.dunlap@oracle.com> <20080807175552.67d5385d.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1628 Lines: 50 > > If someone asks for sisfb then sis drm uses code from it, if they don't > > ask for it it doesn't. So I want sisfb to be built in if its selected and > > sis drm is built-in. > > config DRM_SIS > select FB_SIS Maybe the other way around, I don't want DRM_SIS influencing whether FB_SIS is on or off, if the user wants sisfb on, then when they select it, DRM_SIS should be built in the same way. But if sisfb isn't selected by the user, then selecting DRM_SIS shouldn't enable it. Dave. > > might do it. > > > Maybe I should just rip the dependency out completely, but this patch will > > break stuff badly, if someone was using the SIS DRM without sisfb. > > > > Dave. > > > > > --- > > > drivers/gpu/drm/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > --- linux-next-20080806.orig/drivers/gpu/drm/Kconfig > > > +++ linux-next-20080806/drivers/gpu/drm/Kconfig > > > @@ -86,7 +86,7 @@ config DRM_MGA > > > > > > config DRM_SIS > > > tristate "SiS video cards" > > > - depends on DRM && AGP > > > + depends on DRM && AGP && FB_SIS > > > help > > > Choose this option if you have a SiS 630 or compatible video > > > chipset. If M is selected the module will be called sis. AGP > > --- > ~Randy > Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA > http://linuxplumbersconf.org/ > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/