Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756513AbYHHDMg (ORCPT ); Thu, 7 Aug 2008 23:12:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753285AbYHHDMZ (ORCPT ); Thu, 7 Aug 2008 23:12:25 -0400 Received: from 175.212.DSNET ([203.110.175.212]:12379 "EHLO mail.atheros.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751239AbYHHDMY convert rfc822-to-8bit (ORCPT ); Thu, 7 Aug 2008 23:12:24 -0400 From: Jie Yang To: roel kluin , "jgarzik@redhat.com" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jeff@garzik.org" , "jacliburn@bellsouth.net" Date: Fri, 8 Aug 2008 11:12:20 +0800 Subject: RE: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST? Thread-Topic: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST? Thread-Index: Acj4eP9gvbaPqdPGQCmW1E/15SYX/QAio+SA Message-ID: <72981EBCFD196144B7C6999B9FC34A9A3EE61F99BC@SHEXMB-01.global.atheros.com> References: <489B21CA.7010508@gmail.com> In-Reply-To: <489B21CA.7010508@gmail.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: zh-CN, en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1338 Lines: 39 On Friday, August 08, 2008 12:25 AM roel kluin wrote > > untested, is it right? > --- > WAKE_MCAST bit tested twice, test WAKE_UCAST first. > > Signed-off-by: Roel Kluin diff --git > a/drivers/net/atl1e/atl1e_ethtool.c > b/drivers/net/atl1e/atl1e_ethtool.c > index cdc3b85..619c658 100644 > --- a/drivers/net/atl1e/atl1e_ethtool.c > +++ b/drivers/net/atl1e/atl1e_ethtool.c > @@ -355,7 +355,7 @@ static int atl1e_set_wol(struct > net_device *netdev, struct ethtool_wolinfo *wol) > struct atl1e_adapter *adapter = netdev_priv(netdev); > > if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE | > - WAKE_MCAST | WAKE_BCAST | WAKE_MCAST)) > + WAKE_UCAST | WAKE_MCAST | WAKE_BCAST)) > return -EOPNOTSUPP; > /* these settings will always override what we > currently have */ > adapter->wol = 0; > Yes, it should be this, thanks! Acked-by: Jie Yang BTW: resend on the comments from Jay Cliburn Thanks Jay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/