Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755582AbYHHKmx (ORCPT ); Fri, 8 Aug 2008 06:42:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753445AbYHHKmp (ORCPT ); Fri, 8 Aug 2008 06:42:45 -0400 Received: from sender-03.it.helsinki.fi ([128.214.205.141]:48007 "EHLO sender-03.it.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753075AbYHHKmp (ORCPT ); Fri, 8 Aug 2008 06:42:45 -0400 X-Greylist: delayed 2003 seconds by postgrey-1.27 at vger.kernel.org; Fri, 08 Aug 2008 06:42:44 EDT Date: Fri, 8 Aug 2008 13:09:06 +0300 (EEST) From: Vesa-Matti J Kari X-X-Sender: vmkari@ruuvi.it.helsinki.fi To: James Morris cc: sds@tycho.nsa.gov, eparis@parisplace.org, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov Subject: Re: [PATCH] selinux: conditional expression type validation was off-by-one In-Reply-To: Message-ID: References: <200808061546.m76Fkwq1005199@ruuvi.it.helsinki.fi> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 36 Hello, On Thu, 7 Aug 2008, James Morris wrote: > On Wed, 6 Aug 2008, Vesa-Matti Kari wrote: > > > expr_isvalid() in conditional.c was off-by-one and allowed > > invalid expression type COND_LAST. However, it is this header file > > that needs to be fixed. That way the if-statement's disjunction's > > second component reads more naturally, "if expr type is greater than > > the last allowed value" ( rather than using ">=" in conditional.c): > > > > if (expr->expr_type <= 0 || expr->expr_type > COND_LAST) > > > > Signed-off-by: Vesa-Matti Kari > > Thanks, nice catch. > > Applied to > git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next I also checked out the userspace and the same bug exists in libsepol. Best regards, vmk -- ************************************************************************ Tietotekniikkaosasto / Helsingin yliopisto IT Department / University of Helsinki ************************************************************************ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/