From: Arnd Bergmann <arnd@arndb.de>
To: Carl Love <cel@us.ibm.com>
Subject: Re: [PATCH 2/2] Cell OProfile: SPU mutex lock fix, version 4
Date: Fri, 8 Aug 2008 15:26:20 +0200
User-Agent: KMail/1.9.9
Cc: linuxppc-dev@ozlabs.org, cel <cel@linux.vnet.ibm.com>,
       cbe-oss-dev@ozlabs.org, linux-kernel <linux-kernel@vger.kernel.org>
References: <1217620879.15667.145.camel@carll-linux-desktop>
In-Reply-To: <1217620879.15667.145.camel@carll-linux-desktop>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200808081526.21405.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 808
Lines: 19

On Friday 01 August 2008, Carl Love wrote:
> If an error occurs on opcontrol start, the event and per cpu buffers 
> are released. ?If later opcontrol shutdown is called then the free
> function will be called again to free buffers that no longer 
> exist. ?This results in a kernel oops. ?The following changes
> prevent the call to delete buffers that don't exist.
> 
> Signed-off-by: Carl Love <carll@us.ibm.com>
> 

vfree(NULL) is defined to be legal, so you don't need to check the
argument for being non-NULL, just set it to NULL after the free.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/