Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756374AbYHHQuZ (ORCPT ); Fri, 8 Aug 2008 12:50:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751695AbYHHQuJ (ORCPT ); Fri, 8 Aug 2008 12:50:09 -0400 Received: from xes-mad.com ([216.165.139.214]:38149 "EHLO xes-mad.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbYHHQuH (ORCPT ); Fri, 8 Aug 2008 12:50:07 -0400 Subject: Re: [PATCHv3] leds-pca955x: Add proper error handling and fix bogus memory handling From: Nate Case To: Sven Wegener Cc: rpurdie@rpsys.net, Andrew Morton , linux-kernel In-Reply-To: References: <1210972198.13845.540.camel@localhost.localdomain> Content-Type: text/plain Date: Fri, 08 Aug 2008 11:49:30 -0500 Message-Id: <1218214170.21619.49.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 21 On Fri, 2008-08-08 at 09:27 +0200, Sven Wegener wrote: > Here's a slightly updated patch, with some changes I had forgotten. > Shouldn't change the logic at all. > > - Another 32 -> sizeof() conversion > - Move the unregister code to where we also free the memory on failure > > And one more > > - cancel_work_sync() when unregistering on failure This looks good to me. I won't be able to test it until Monday though. -- Nate Case -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/