Date: Fri, 8 Aug 2008 13:32:41 -0700
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, torvalds@linux-foundation.org,
       mingo@elte.hu, tglx@linutronix.de, marcin.slusarz@gmail.com,
       linux-kernel@vger.kernel.org, davem@davemloft.net, rostedt@goodmis.org
Subject: Re: [PATCH] printk: robustify printk
Message-ID: <20080808203241.GH6760@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <1218202249.8625.106.camel@twins> <alpine.LFD.1.10.0808080931550.3462@nehalem.linux-foundation.org> <1218215454.8625.133.camel@twins> <alpine.LFD.1.10.0808081014240.3462@nehalem.linux-foundation.org> <1218217257.29098.2.camel@lappy.programming.kicks-ass.net> <alpine.LFD.1.10.0808081043160.3462@nehalem.linux-foundation.org> <1218219269.29098.5.camel@lappy.programming.kicks-ass.net> <20080808121428.646a8b3c.akpm@linux-foundation.org> <1218223269.29098.12.camel@lappy.programming.kicks-ass.net> <20080808123747.0db1c5dd.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080808123747.0db1c5dd.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.15+20070412 (2007-04-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2686
Lines: 66

On Fri, Aug 08, 2008 at 12:37:47PM -0700, Andrew Morton wrote:
> On Fri, 08 Aug 2008 21:21:08 +0200
> Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> 
> > On Fri, 2008-08-08 at 12:14 -0700, Andrew Morton wrote:
> > > On Fri, 08 Aug 2008 20:14:28 +0200
> > > Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > > 
> > > >  void wake_up_klogd(void)
> > > >  {
> > > > -	if (!oops_in_progress && waitqueue_active(&log_wait))
> > > > -		wake_up_interruptible(&log_wait);
> > > > +	unsigned long flags;
> > > > +	struct klogd_wakeup_state *kws;
> > > > +
> > > > +	if (!waitqueue_active(&log_wait))
> > > > +		return;
> > > > +
> > > > +	local_irq_save(flags);
> > > > +	kws = &__get_cpu_var(kws);
> > > > +	if (!kws->pending) {
> > > > +		kws->pending = 1;
> > > > +		call_rcu(&kws->head, __wake_up_klogd);
> > > > +	}
> > > > +	local_irq_restore(flags);
> > > >  }
> > > 
> > > Note that kernel/rcupreempt.c's flavour of call_rcu() takes
> > > RCU_DATA_ME().lock, so there are still code sites from which a printk
> > > can deadlock.  Only now, it is config-dependent.
> > > 
> > > From a quick look it appears that large amounts of kernel/rcupreempt.c
> > > are now a printk-free zone.
> > 
> > Drad, missed that bit, I did look at the calling end, but forgot the
> > call_rcu() end :-/
> > 
> > The initial printk_tick() based implementation didn't suffer this
> > problem, should we revert to that scheme?
> 
> Dunno.  Perhaps we could convert RCU_DATA_ME's spinlock_t into an
> rwlock and do read_lock() in call_rcu()?  Then we can should be able to
> call printk from inside that read_lock(), but not inside write_lock(),
> which, with suitable warning comments might be acceptable.
> 
> afacit everything in call_rcu()'s *rdp is cpu-local and is protected by
> local_irq_save().  rcu_ctrlblk.completed and rcu_flipped need some
> protection, but a) rdp->lock isn't sufficient anyway and b)
> read_lock protection would suffice.  Maybe other CPUs can alter *rdp
> while __rcu_advance_callbacks() is running.
> 
> Anyway, that's all handwaving.  My point is that making rcupreempt.c
> more robust and more concurrent might be an alternative fix, and might
> be beneficial in its own right.  Working out the details is what we
> have Pauls for ;)

How about if I instead add comments warning people not to put printk()
in the relevant RCU-implementation code?  That way I can be not only lazy,
but cowardly as well!  ;-)

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/